From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Sun, 15 May 2011 08:41:51 +0100 Subject: [PATCH v4 1/7] MTD: Add integrator-flash feature to physmap In-Reply-To: <1300367028-3916-2-git-send-email-marc.zyngier@arm.com> References: <1300367028-3916-1-git-send-email-marc.zyngier@arm.com> <1300367028-3916-2-git-send-email-marc.zyngier@arm.com> Message-ID: <20110515074150.GA22975@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Mar 17, 2011 at 01:03:42PM +0000, Marc Zyngier wrote: > diff --git a/include/linux/mtd/physmap.h b/include/linux/mtd/physmap.h > index bcfd9f7..d37cca0 100644 > --- a/include/linux/mtd/physmap.h > +++ b/include/linux/mtd/physmap.h > @@ -22,6 +22,8 @@ struct map_info; > > struct physmap_flash_data { > unsigned int width; > + int (*init)(struct platform_device *); > + void (*exit)(struct platform_device *); > void (*set_vpp)(struct map_info *, int); Does anything use the map_info argument to set_vpp? If not, passing a platform_device pointer would be more consistent and useful here.