From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: device_tree binding for "amba bus"
Date: Tue, 17 May 2011 23:41:34 +0100 [thread overview]
Message-ID: <20110517224134.GC2266@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <f9ae780a-2747-427f-826a-e0b510ca8afb@VA3EHSMHS001.ehs.local>
On Tue, May 17, 2011 at 01:28:33PM -0700, Stephen Neuendorffer wrote:
> None of this seems terribly interesting enough to justify a bus that has
> a small number of users:
However, without this infrastructure, drivers have to start doing those
three points you bring up themselves, manually, with additional code,
which makes for additional bugs. No thanks. Let's keep the bus
abstraction there as it serves to ensure that the right things happen
at the right time.
> And at the very least the hardcoded nature of the names seems, well...
> hardcoded.
What hardcoded names? Driver names no matter what bus are part of the
_userspace_ API - remember that almost everything in the device model
is exported to userspace and is therefore part of the kernel's userspace
API. So logically the driver names do want to be stable.
> Any thoughts about how to abstract this in a device tree?
> (My thoughts: devices need to reference a clock, devices need to
> reference a regulator,
> and it seems to me that the register check could be pulled out into a
> single call that the
> devices that care about it can do themselves during probe() )
And another during their remove callback - and where do they store the
data associated with that? Will the drivers need to have a certain
base driver_data structure?
This all sounds like getting rather icky and prone to bugs.
next prev parent reply other threads:[~2011-05-17 22:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 20:28 device_tree binding for "amba bus" Stephen Neuendorffer
2011-05-17 22:41 ` Russell King - ARM Linux [this message]
2011-05-18 0:05 ` Stephen Neuendorffer
2011-05-18 0:23 ` Russell King - ARM Linux
2011-05-18 3:13 ` Grant Likely
2011-05-18 0:24 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110517224134.GC2266@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).