From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] OMAP3BEAGLE: Add support for mt9p031 sensor (LI-5M03 module).
Date: Wed, 18 May 2011 00:08:21 +0100 [thread overview]
Message-ID: <20110517230821.GA5913@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1305624528-5595-3-git-send-email-javier.martin@vista-silicon.com>
On Tue, May 17, 2011 at 11:28:48AM +0200, Javier Martin wrote:
> +#include "devices.h"
> +#include "../../../drivers/media/video/omap3isp/isp.h"
> +#include "../../../drivers/media/video/omap3isp/ispreg.h"
This suggests that there's something very wrong with what's going on;
it suggests that you're trying to access driver internals which should
be handled via some better means. And it looks like it's this:
> @@ -654,6 +715,62 @@ static void __init beagle_opp_init(void)
> return;
> }
>
> +extern struct platform_device omap3isp_device;
> +
> +static int beagle_cam_set_xclk(struct v4l2_subdev *subdev, int hz)
> +{
> + struct isp_device *isp = platform_get_drvdata(&omap3isp_device);
> + int ret;
> +
> + ret = isp->platform_cb.set_xclk(isp, hz, MT9P031_XCLK);
> + return 0;
> +}
That really needs fixing in a different way.
next prev parent reply other threads:[~2011-05-17 23:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 9:28 No subject Javier Martin
2011-05-17 9:28 ` [PATCH 1/2] mt9p031: Add mt9p031 sensor driver Javier Martin
2011-05-17 11:33 ` Laurent Pinchart
2011-05-17 11:47 ` Guennadi Liakhovetski
2011-05-17 11:59 ` javier Martin
2011-05-17 17:14 ` Ivan Nazarenko
2011-05-18 10:34 ` javier Martin
2011-05-17 23:18 ` Russell King - ARM Linux
2011-05-18 9:10 ` javier Martin
2011-05-18 14:23 ` Laurent Pinchart
2011-05-17 9:28 ` [PATCH 2/2] OMAP3BEAGLE: Add support for mt9p031 sensor (LI-5M03 module) Javier Martin
2011-05-17 23:08 ` Russell King - ARM Linux [this message]
2011-05-18 7:50 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110517230821.GA5913@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).