From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: Add Cortex A5 proc_info
Date: Wed, 18 May 2011 11:53:08 +0100 [thread overview]
Message-ID: <20110518105308.GA2544@arm.com> (raw)
In-Reply-To: <1305712038.17656.41.camel@hornet.cambridge.arm.com>
On Wed, May 18, 2011 at 10:47:18AM +0100, Pawel Moll wrote:
> > + .long 0x410fc050 @ Required ID value
> > + .long 0xff0ffff0 @ Mask for ID
>
> Alternatively I could "reuse" current A9 proc_info and change ID value
> and mask to:
>
> 0x410fc010
> 0xff0fff30
>
> This would:
>
> * match Cortex A5 (part no. 0xc05) and A9 (0xc09)
>
> * not match A8 (0xc08) and A15 (0xc0f)
>
> Everything is fine so far, but also:
>
> * match part no. 0xc01 and 0xc0d
>
> Obviously no parts like that exist today, but somehow this "solution"
> doesn't appeal to me... Of course it would save 39 lines in diff
> stat ;-)
If we're worried about the ambiguity/duplication, maybe the proc_info
structure format could be extended to allow multiple match specifications,
or a level of indirection could be introduced.
Dunno whether it's worth it though. It partly depends on how often we
expect this kind of duplication to occur.
The simplest solution might be to use a macro to avoid duplication in
the source. This would still create diffstat noise, but it's not
actually fragmentary, so it may be considered OK.
See what other people think, I guess.
---Dave
next prev parent reply other threads:[~2011-05-18 10:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-17 16:49 [PATCH] arm: Add Cortex A5 proc_info Pawel Moll
2011-05-18 9:47 ` Pawel Moll
2011-05-18 10:53 ` Dave Martin [this message]
2011-05-18 12:06 ` Pawel Moll
2011-05-18 16:44 ` [PATCH v2] arm: Add Cortex A5 proc info Pawel Moll
2011-05-19 14:10 ` Will Deacon
2011-05-19 15:31 ` Pawel Moll
2011-05-19 16:08 ` Dave Martin
2011-05-20 9:14 ` Will Deacon
2011-05-20 11:51 ` Pawel Moll
2011-05-20 13:39 ` [PATCH v3 1/2] arm: Convert v7 proc infos into a common macro Pawel Moll
2011-05-20 13:39 ` [PATCH v3 2/2] arm: Add Cortex A5 proc info Pawel Moll
2011-05-20 14:32 ` Will Deacon
2011-05-20 14:31 ` [PATCH v3 1/2] arm: Convert v7 proc infos into a common macro Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110518105308.GA2544@arm.com \
--to=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).