From: magnus.damm@gmail.com (Magnus Damm)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Enable GIC support when TWD is selected
Date: Thu, 19 May 2011 09:24:48 +0900 [thread overview]
Message-ID: <20110519002448.357.5477.sendpatchset@t400s> (raw)
From: Magnus Damm <damm@opensource.se>
The TWD code in smp_twd.c has been calling gic_enable_ppi()
since ac61d143ffe2a6db4d4bcf47c21a5159d6a1b644.
Without this fix kernel configs with CONFIG_HAVE_ARM_TWD=y
and CONFIG_ARM_GIC=n results in the following build error:
arch/arm/kernel/built-in.o: In function `twd_timer_setup':
io.c:(.cpuinit.text+0x580): undefined reference to `gic_enable_ppi'
make: *** [.tmp_vmlinux1] Error 1
Signed-off-by: Magnus Damm <damm@opensource.se>
---
Or perhaps mach-shmobile should always select ARM_GIC even
though some SoC parts do not include GIC hardware?
arch/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- 0001/arch/arm/Kconfig
+++ work/arch/arm/Kconfig 2011-05-03 10:40:26.000000000 +0900
@@ -1368,6 +1368,7 @@ config HAVE_ARM_TWD
bool
depends on SMP
select TICK_ONESHOT
+ select ARM_GIC
help
This options enables support for the ARM timer and watchdog unit
reply other threads:[~2011-05-19 0:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110519002448.357.5477.sendpatchset@t400s \
--to=magnus.damm@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).