* [PATCH] ARM: Enable GIC support when TWD is selected
@ 2011-05-19 0:24 Magnus Damm
0 siblings, 0 replies; only message in thread
From: Magnus Damm @ 2011-05-19 0:24 UTC (permalink / raw)
To: linux-arm-kernel
From: Magnus Damm <damm@opensource.se>
The TWD code in smp_twd.c has been calling gic_enable_ppi()
since ac61d143ffe2a6db4d4bcf47c21a5159d6a1b644.
Without this fix kernel configs with CONFIG_HAVE_ARM_TWD=y
and CONFIG_ARM_GIC=n results in the following build error:
arch/arm/kernel/built-in.o: In function `twd_timer_setup':
io.c:(.cpuinit.text+0x580): undefined reference to `gic_enable_ppi'
make: *** [.tmp_vmlinux1] Error 1
Signed-off-by: Magnus Damm <damm@opensource.se>
---
Or perhaps mach-shmobile should always select ARM_GIC even
though some SoC parts do not include GIC hardware?
arch/arm/Kconfig | 1 +
1 file changed, 1 insertion(+)
--- 0001/arch/arm/Kconfig
+++ work/arch/arm/Kconfig 2011-05-03 10:40:26.000000000 +0900
@@ -1368,6 +1368,7 @@ config HAVE_ARM_TWD
bool
depends on SMP
select TICK_ONESHOT
+ select ARM_GIC
help
This options enables support for the ARM timer and watchdog unit
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-05-19 0:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-19 0:24 [PATCH] ARM: Enable GIC support when TWD is selected Magnus Damm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).