From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio
Date: Sat, 21 May 2011 14:03:02 +0100 [thread overview]
Message-ID: <20110521130302.GA4111@pulham.picochip.com> (raw)
In-Reply-To: <0D753D10438DA54287A00B027084269764D30C10DC@AUSP01VMBX24.collaborationhost.net>
On Fri, May 20, 2011 at 05:07:12PM -0500, H Hartley Sweeten wrote:
> On Thursday, May 19, 2011 6:50 PM, Jamie Iles wrote:
> > diff --git a/drivers/gpio/Makefile b/drivers/gpio/Makefile
> > index becef59..aa9e97f 100644
> > --- a/drivers/gpio/Makefile
> > +++ b/drivers/gpio/Makefile
> > @@ -10,6 +10,7 @@ obj-$(CONFIG_GPIOLIB) += gpiolib.o
> >
> > obj-$(CONFIG_GPIO_ADP5520) += adp5520-gpio.o
> > obj-$(CONFIG_GPIO_ADP5588) += adp5588-gpio.o
> > +obj-$(CONFIG_GPIO_BASIC_MMIO_CORE) += basic_mmio_gpio.o
> > obj-$(CONFIG_GPIO_BASIC_MMIO) += basic_mmio_gpio.o
>
> I think the line above should be removed. GPIO_BASIC_MMIO selects
> GPIO_BASIC_MMIO_CORE so the line you added previous to it will cause
> basic_mmio_gpio to be compiled.
>
> GPIO_BASIC_MMIO is really just used in the driver to enable the code
> at the end which creates the generic gbpio_driver.
Yes, well spotted. I'll create a patch to remove this.
Jamie
next prev parent reply other threads:[~2011-05-21 13:03 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-27 13:13 [PATCH 02/10] mach-u300: rewrite gpio driver, move to drivers/gpio Linus Walleij
2011-04-27 18:23 ` H Hartley Sweeten
2011-04-28 7:07 ` Linus Walleij
2011-04-28 7:10 ` Linus Walleij
2011-04-28 17:41 ` H Hartley Sweeten
2011-05-13 14:51 ` Linus Walleij
2011-05-19 8:56 ` Shawn Guo
2011-05-19 12:21 ` Linus Walleij
2011-05-19 13:56 ` Shawn Guo
2011-05-19 19:11 ` Sascha Hauer
2011-05-19 19:30 ` Nicolas Pitre
2011-05-20 3:18 ` Shawn Guo
2011-05-20 3:43 ` Kyungmin Park
2011-05-20 3:54 ` Nicolas Pitre
2011-05-19 21:18 ` H Hartley Sweeten
2011-05-20 1:50 ` Jamie Iles
2011-05-20 22:07 ` H Hartley Sweeten
2011-05-21 13:03 ` Jamie Iles [this message]
2011-05-20 7:01 ` Grant Likely
2011-05-20 7:47 ` Linus Walleij
[not found] ` <BANLkTi=poU17RqAzp28CPjWHrN_+aFiyag@mail.gmail.com>
2011-05-19 11:38 ` Barry Song
2011-05-19 12:25 ` Linus Walleij
2011-05-19 12:35 ` Barry Song
2011-05-19 13:17 ` Linus Walleij
2011-05-19 14:05 ` Barry Song
2011-05-20 6:58 ` Grant Likely
2011-05-20 6:52 ` Grant Likely
2011-05-20 7:46 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110521130302.GA4111@pulham.picochip.com \
--to=jamie@jamieiles.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).