[PATCH v2 0/4] Samsung: Move Samsung SoCs GPIO drivers to drivers/gpio

[PATCH v2 0/4] Samsung: Move Samsung SoCs GPIO drivers to drivers/gpio

[Kyungmin Park]

The following changes since commit dcb4a1f0e0367efb813907e5083998bbb98b0456:

  Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6 (2011-05-21 12:25:07 -0700)

Kyungmin Park (4):
      Move to Samsung common GPIO library to drivers/gpio
      Move the exynos4 GPIO to drivers/gpio
      Move the s5pv210 GPIO to drivers/gpio
      Move the s5pc100 GPIO to drivers/gpio

Changelog v2:
	Use the gpio-* prefix by Grant

Note that: gpio-samsung.c will be used as common samsung gpio file

 arch/arm/mach-exynos4/Makefile     |    2
 arch/arm/mach-exynos4/gpiolib.c    |  365 ------------------------------------
 arch/arm/mach-s5pc100/Makefile     |    2
 arch/arm/mach-s5pc100/gpiolib.c    |  355 -----------------------------------
 arch/arm/mach-s5pv210/Makefile     |    2
 arch/arm/mach-s5pv210/gpiolib.c    |  288 -----------------------------
 arch/arm/plat-samsung/Makefile     |    1
 arch/arm/plat-samsung/gpiolib.c    |  206 --------------------
 b/arch/arm/mach-exynos4/Makefile   |    2
 b/arch/arm/mach-s5pc100/Makefile   |    2
 b/arch/arm/mach-s5pv210/Makefile   |    2
 b/arch/arm/plat-samsung/Makefile   |    1
 b/drivers/gpio/Kconfig             |   24 ++
 b/drivers/gpio/Makefile            |    4
 b/drivers/gpio/gpio-exynos4.c      |  366 ++++++++++++++++++++++++++++++++++++-
 b/drivers/gpio/gpio-plat-samsung.c |  207 ++++++++++++++++++++
 b/drivers/gpio/gpio-s5pc100.c      |  356 +++++++++++++++++++++++++++++++++++
 b/drivers/gpio/gpio-s5pv210.c      |  289 +++++++++++++++++++++++++++++
 b/drivers/gpio/samsung-gpiolib.c   |    3
 drivers/gpio/Kconfig               |   24 ++
 drivers/gpio/Makefile              |    4
 21 files changed, 1278 insertions(+), 1227 deletions(-)

[PATCH v2 0/4] Samsung: Move Samsung SoCs GPIO drivers to drivers/gpio

[Grant Likely]

On Mon, May 23, 2011 at 05:27:28PM +0900, Kyungmin Park wrote:
> The following changes since commit dcb4a1f0e0367efb813907e5083998bbb98b0456:
> 
>   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ieee1394/linux1394-2.6 (2011-05-21 12:25:07 -0700)

Applied whole series, thanks.

g.

[PATCH v2 0/4] Samsung: Move Samsung SoCs GPIO drivers to drivers/gpio

[Kyungmin Park]

On Thu, Jun 9, 2011 at 1:05 PM, Bhuvana Kakunoori
<bhuvana.kakunoori@linaro.org> wrote:
> Hi Kyungmin,
>
> This is regards to the patch submitted by you at
> http://www.spinics.net/lists/arm-kernel/msg125861.html
> I didnt have the thread in my mailbox, so starting another thread.
> Can you please let me know, what were your plans for consolidation when you
> moved these folders to drivers/gpio?

At least s5p100, s5pc110, and s5pc210 (aka exynos4) gpio drivers are
moved and merged already.
I want to make a simplified GPIO drivers for Samsung GPIOs.

e.g., most recent (please ignore the old s3c24xx series GPIOs) SoCs
use the 4-bit based GPIOs and has 8 pins at each banks.
so it can defined as below and use the macro at drivers.

#define SAMSUNG_GPIO(group, n)    (((group) * 8) + (n))
enum s5pv210_gpio_groups {
           S5PV210_GPA0,
           S5PV210_GPA1,
           ...
};

SAMSUNG_GPIO(S5PV210_GPA0, n);

In the view of files & directories
drivers/gpio/gpio-samsung.c for generic samsung gpio drivers.
pass the required information with platform data. then driver got the
platform data and register each gpio groups.
it only defined the how many gpio banks are required and its base address.
Of course there's special case, external GPIOs. then we set the flags
as SAMSUNG_EXTERNAL_GPIO_FLAGS
and register it as external gpios.

I also consider to use the basic_mmio_gpios but it required to modify
and need to expand for our use case since pullup and strength
handling. but finally these are also should be moved to proper
framework. as it's not defined at generic gpio drivers. Maybe pinmux
can handle these.

Do you have any ideas or opinions. then please let me know.

Thank you,
Kyungmin Park

> I was looking into the gpio code for samsung platforms, and wanted to know
> what you are working on.
>
> Regards
> Bhuvana
>