From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix missing 'cpu_relax()' declaration
Date: Mon, 23 May 2011 17:41:23 +0100 [thread overview]
Message-ID: <20110523164123.GD15138@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1306168473.27474.88.camel@e102391-lin.cambridge.arm.com>
On Mon, May 23, 2011 at 05:34:33PM +0100, Marc Zyngier wrote:
> On Mon, 2011-05-23 at 17:23 +0100, Russell King - ARM Linux wrote:
> > Hmm, this doesn't fix the problem:
> >
> > CC arch/arm/kernel/asm-offsets.s
> > In file included from include/linux/seqlock.h:29,
> > from include/linux/time.h:8,
> > from include/linux/timex.h:56,
> > from include/linux/sched.h:57,
> > from arch/arm/kernel/asm-offsets.c:13:
> > include/linux/spinlock.h: In function ?spin_unlock_wait?:
> > include/linux/spinlock.h:360: error: implicit declaration of function ?cpu_relax?
> >
> > My guess is that it does for you because you're building SMP, but the above
> > also happens with UP. So, I don't think this is the right fix.
> >
> > I think its time to use git bisect to try and find what broke this and why.
>
> Odd... It seems to build just fine here with UP:
>
> $ grep SMP .config
> CONFIG_BROKEN_ON_SMP=y
> # CONFIG_SMP is not set
> $ time make ARCH=arm CROSS_COMPILE=arm-none-linux-gnueabi- -j4 all
> CHK include/linux/version.h
> HOSTCC scripts/basic/fixdep
> HOSTCC scripts/basic/docproc
> HOSTCC scripts/kallsyms
> HOSTCC scripts/conmakehash
> CC scripts/mod/empty.o
> HOSTCC scripts/mod/mk_elfconfig
> MKELF scripts/mod/elfconfig.h
> HOSTCC scripts/mod/file2alias.o
> HOSTCC scripts/mod/modpost.o
> HOSTCC scripts/mod/sumversion.o
> HOSTLD scripts/mod/modpost
> CHK include/generated/utsrelease.h
> make[1]: `include/generated/mach-types.h' is up to date.
> CC kernel/bounds.s
> GEN include/generated/bounds.h
> CC arch/arm/kernel/asm-offsets.s
> GEN include/generated/asm-offsets.h
> CALL scripts/checksyscalls.sh
> <stdin>:1554: warning: #warning syscall sendmmsg not implemented
> CC init/main.o
> CHK include/generated/compile.h
> HOSTCC usr/gen_init_cpio
> [...]
For what platform? I've tried a few and getting the same error message.
next prev parent reply other threads:[~2011-05-23 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 13:33 [PATCH] ARM: fix missing 'cpu_relax()' declaration Marc Zyngier
2011-05-23 16:09 ` Russell King - ARM Linux
2011-05-23 16:23 ` Marc Zyngier
2011-05-23 16:23 ` Russell King - ARM Linux
2011-05-23 16:34 ` Marc Zyngier
2011-05-23 16:41 ` Russell King - ARM Linux [this message]
2011-05-23 16:45 ` Russell King - ARM Linux
2011-05-23 16:49 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110523164123.GD15138@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox