[PATCH 3/4] davinci: dm646x: remove the macros from the header to move to c file

[plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)]

On 19:04 Mon 23 May     , Nori, Sekhar wrote:
> 
> Hi Jean-Christophe,
> 
> On Fri, May 20, 2011 at 19:54:01, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 19:42 Fri 20 May     , Manjunath Hadli wrote:
> > > move the register base addresses and offsets used only by dm646x
> > > platform file from platform header dm646x.h to dm646x.c as they
> > > are used only in the c file.
> > > 
> > > Signed-off-by: Manjunath Hadli <manjunath.hadli@ti.com>
> > I do not think it's a good idea to put the register mapping in the c file
> > evenif they are used only today in dm646x
> > 
> 
> Unless a definition is used across C files, it would be better to
> keep it local to the C file. Why treat base addresses and register
> offsets differently?
no difference the macro are nearly every time put in header not in C code

ditto of ifdef

Best Regards,
J.