From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [GIT PULL] pxa: for next merge
Date: Wed, 25 May 2011 00:19:16 +0100 [thread overview]
Message-ID: <20110524231916.GD4652@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <BANLkTin8tX_kfG_R6To+ktNbOW+B93LiqQ@mail.gmail.com>
I've just spotted this:
+asmlinkage void __exception_irq_entry icip_handle_irq(struct pt_regs *regs)
+{
+ uint32_t icip, icmr, mask;
+
+ do {
+ icip = __raw_readl(IRQ_BASE + ICIP);
+ icmr = __raw_readl(IRQ_BASE + ICMR);
+ mask = icip & icmr;
+
+ if (mask == 0)
+ break;
+
+ asm_do_IRQ(fls(mask) - 1, regs);
+ } while (1);
+}
This is bad news. A function marked as __exception is expected to be
called from the assembly code. The above is fine, but it then goes on
to call asm_do_IRQ() which is also marked __exception.
This means the unwinder will attempt to dump the saved pt_regs register
state for both asm_do_IRQ() and icip_handle_irq(), resulting in one of
them being garbage.
So I think this needs some thought.
Second point - can't the USB changes go via the USB people? Have USB
people seen the patch?
next prev parent reply other threads:[~2011-05-24 23:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-21 5:17 [GIT PULL] pxa: for next merge Eric Miao
2011-05-24 23:19 ` Russell King - ARM Linux [this message]
2011-05-25 8:15 ` Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110524231916.GD4652@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).