* [PATCH] arm: mxs: include asm/processor.h for cpu_relax()
@ 2011-05-25 9:34 Wolfram Sang
2011-05-25 10:44 ` Shawn Guo
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Wolfram Sang @ 2011-05-25 9:34 UTC (permalink / raw)
To: linux-arm-kernel
I get this build error as of today:
arch/arm/mach-mxs/ocotp.c: In function 'mxs_get_ocotp':
arch/arm/mach-mxs/ocotp.c:54: error: implicit declaration of function 'cpu_relax'
make[2]: *** [arch/arm/mach-mxs/ocotp.o] Error 1
Looks like it has been indirectly included before which broke now.
Include it directly.
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Cc: Shawn Guo <shawn.guo@freescale.com>
---
arch/arm/mach-mxs/ocotp.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-mxs/ocotp.c b/arch/arm/mach-mxs/ocotp.c
index 65157a3..54add60 100644
--- a/arch/arm/mach-mxs/ocotp.c
+++ b/arch/arm/mach-mxs/ocotp.c
@@ -16,6 +16,8 @@
#include <linux/err.h>
#include <linux/mutex.h>
+#include <asm/processor.h> /* for cpu_relax() */
+
#include <mach/mxs.h>
#define OCOTP_WORD_OFFSET 0x20
--
1.7.2.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] arm: mxs: include asm/processor.h for cpu_relax()
2011-05-25 9:34 [PATCH] arm: mxs: include asm/processor.h for cpu_relax() Wolfram Sang
@ 2011-05-25 10:44 ` Shawn Guo
2011-05-25 10:47 ` Wolfram Sang
2011-05-25 11:46 ` Shawn Guo
2011-06-29 7:10 ` Shawn Guo
2 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2011-05-25 10:44 UTC (permalink / raw)
To: linux-arm-kernel
Hi Wolfram,
On Wed, May 25, 2011 at 11:34:57AM +0200, Wolfram Sang wrote:
> I get this build error as of today:
>
> arch/arm/mach-mxs/ocotp.c: In function 'mxs_get_ocotp':
> arch/arm/mach-mxs/ocotp.c:54: error: implicit declaration of function 'cpu_relax'
> make[2]: *** [arch/arm/mach-mxs/ocotp.o] Error 1
>
May I know the tree you are seeing this error with?
--
Regards,
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: mxs: include asm/processor.h for cpu_relax()
2011-05-25 9:34 [PATCH] arm: mxs: include asm/processor.h for cpu_relax() Wolfram Sang
2011-05-25 10:44 ` Shawn Guo
@ 2011-05-25 11:46 ` Shawn Guo
2011-06-29 7:10 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2011-05-25 11:46 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, May 25, 2011 at 11:34:57AM +0200, Wolfram Sang wrote:
> I get this build error as of today:
>
> arch/arm/mach-mxs/ocotp.c: In function 'mxs_get_ocotp':
> arch/arm/mach-mxs/ocotp.c:54: error: implicit declaration of function 'cpu_relax'
> make[2]: *** [arch/arm/mach-mxs/ocotp.o] Error 1
>
> Looks like it has been indirectly included before which broke now.
> Include it directly.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Shawn Guo <shawn.guo@freescale.com>
> ---
Acked-by: Shawn Guo <shawn.guo@freescale.com>
--
Regards,
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: mxs: include asm/processor.h for cpu_relax()
2011-05-25 9:34 [PATCH] arm: mxs: include asm/processor.h for cpu_relax() Wolfram Sang
2011-05-25 10:44 ` Shawn Guo
2011-05-25 11:46 ` Shawn Guo
@ 2011-06-29 7:10 ` Shawn Guo
2011-06-29 20:25 ` Sascha Hauer
2 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2011-06-29 7:10 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sascha,
Can you apply this patch on your for-next?
Regards,
Shawn
On Wed, May 25, 2011 at 11:34:57AM +0200, Wolfram Sang wrote:
> I get this build error as of today:
>
> arch/arm/mach-mxs/ocotp.c: In function 'mxs_get_ocotp':
> arch/arm/mach-mxs/ocotp.c:54: error: implicit declaration of function 'cpu_relax'
> make[2]: *** [arch/arm/mach-mxs/ocotp.o] Error 1
>
> Looks like it has been indirectly included before which broke now.
> Include it directly.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Shawn Guo <shawn.guo@freescale.com>
> ---
> arch/arm/mach-mxs/ocotp.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-mxs/ocotp.c b/arch/arm/mach-mxs/ocotp.c
> index 65157a3..54add60 100644
> --- a/arch/arm/mach-mxs/ocotp.c
> +++ b/arch/arm/mach-mxs/ocotp.c
> @@ -16,6 +16,8 @@
> #include <linux/err.h>
> #include <linux/mutex.h>
>
> +#include <asm/processor.h> /* for cpu_relax() */
> +
> #include <mach/mxs.h>
>
> #define OCOTP_WORD_OFFSET 0x20
> --
> 1.7.2.5
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] arm: mxs: include asm/processor.h for cpu_relax()
2011-06-29 7:10 ` Shawn Guo
@ 2011-06-29 20:25 ` Sascha Hauer
0 siblings, 0 replies; 6+ messages in thread
From: Sascha Hauer @ 2011-06-29 20:25 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jun 29, 2011 at 03:10:27PM +0800, Shawn Guo wrote:
> Hi Sascha,
>
> Can you apply this patch on your for-next?
Done
Sascha
>
> Regards,
> Shawn
>
> On Wed, May 25, 2011 at 11:34:57AM +0200, Wolfram Sang wrote:
> > I get this build error as of today:
> >
> > arch/arm/mach-mxs/ocotp.c: In function 'mxs_get_ocotp':
> > arch/arm/mach-mxs/ocotp.c:54: error: implicit declaration of function 'cpu_relax'
> > make[2]: *** [arch/arm/mach-mxs/ocotp.o] Error 1
> >
> > Looks like it has been indirectly included before which broke now.
> > Include it directly.
> >
> > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> > Cc: Shawn Guo <shawn.guo@freescale.com>
> > ---
> > arch/arm/mach-mxs/ocotp.c | 2 ++
> > 1 files changed, 2 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/mach-mxs/ocotp.c b/arch/arm/mach-mxs/ocotp.c
> > index 65157a3..54add60 100644
> > --- a/arch/arm/mach-mxs/ocotp.c
> > +++ b/arch/arm/mach-mxs/ocotp.c
> > @@ -16,6 +16,8 @@
> > #include <linux/err.h>
> > #include <linux/mutex.h>
> >
> > +#include <asm/processor.h> /* for cpu_relax() */
> > +
> > #include <mach/mxs.h>
> >
> > #define OCOTP_WORD_OFFSET 0x20
> > --
> > 1.7.2.5
> >
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-29 20:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-25 9:34 [PATCH] arm: mxs: include asm/processor.h for cpu_relax() Wolfram Sang
2011-05-25 10:44 ` Shawn Guo
2011-05-25 10:47 ` Wolfram Sang
2011-05-25 11:46 ` Shawn Guo
2011-06-29 7:10 ` Shawn Guo
2011-06-29 20:25 ` Sascha Hauer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).