From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoc: wm8731: fix wm8731_check_osc() connected condition
Date: Wed, 25 May 2011 19:15:30 +0800 [thread overview]
Message-ID: <20110525111529.GC10797@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1306230657-28649-1-git-send-email-nicolas.ferre@atmel.com>
On Tue, May 24, 2011 at 11:50:57AM +0200, Nicolas Ferre wrote:
> The crystal oscillator is only enabled if the WM8731_SYSCLK_XTAL master clock
> is specified. Fix the connected() struct snd_soc_dapm_route function to take
> this into account. Oscillator is not enabled on machine that need it otherwise.
>
> Machine drivers have to make sure that they use the proper SYSCLK value.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Adding Liam - Nicolas, please remember to CC all maintainers on patches.
> ---
> sound/soc/codecs/wm8731.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8731.c b/sound/soc/codecs/wm8731.c
> index 6dec7ce..2dc964b 100644
> --- a/sound/soc/codecs/wm8731.c
> +++ b/sound/soc/codecs/wm8731.c
> @@ -198,7 +198,7 @@ static int wm8731_check_osc(struct snd_soc_dapm_widget *source,
> {
> struct wm8731_priv *wm8731 = snd_soc_codec_get_drvdata(source->codec);
>
> - return wm8731->sysclk_type == WM8731_SYSCLK_MCLK;
> + return wm8731->sysclk_type == WM8731_SYSCLK_XTAL;
> }
>
> static const struct snd_soc_dapm_route wm8731_intercon[] = {
> --
> 1.7.3
>
next prev parent reply other threads:[~2011-05-25 11:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-24 9:50 [PATCH] ASoc: wm8731: fix wm8731_check_osc() connected condition Nicolas Ferre
2011-05-25 11:15 ` Mark Brown [this message]
2011-05-25 12:11 ` Liam Girdwood
2011-05-25 15:01 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110525111529.GC10797@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).