From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] dmaengine: add TODO items for future work on dma drivers
Date: Thu, 26 May 2011 14:38:58 +0100 [thread overview]
Message-ID: <20110526133858.GI24876@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1306412730.2230.0.camel@vkoul-udesk3>
On Thu, May 26, 2011 at 05:55:30PM +0530, Koul, Vinod wrote:
> > I'd suggest adding some more to this:
> >
> > 4. Remove dma_slave_config's dma direction.
> >
> > It's pointless that dma_slave_config carries the DMA direction (to/from
> > device) and the prepare function does too. It leads to DMA engine drivers
> > having to verify that the two match, and DMA engine users having to issue
> > two calls every time they change direction.
> >
> > Instead, lets specify that dma_slave_config carries the _device_ side
> > parameters, which are selected according to the direction given to the
> > prepare function. The memory-side parameters should be selected by the
> > DMA engine driver according to its knowledge of the system.
> >
> > This is sensible as M2M transfers don't allow configuration and therefore
> > already have to select these parameters internally.
> Sure, I am adding this as well and applying both patches
Thanks. In which case I'll mention that I already have patches to make
the PL08x driver do this.
prev parent reply other threads:[~2011-05-26 13:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 11:39 [PATCH v2 0/2] dmaengine: add slave documentation Koul, Vinod
2011-05-25 11:39 ` [PATCH 1/2] dmaengine: Add API documentation for slave dma usage Koul, Vinod
2011-05-25 11:39 ` [PATCH 2/2] dmaengine: add TODO items for future work on dma drivers Koul, Vinod
2011-05-25 12:39 ` Per Forlin
2011-05-25 12:15 ` Koul, Vinod
2011-05-25 12:54 ` Per Forlin
2011-05-25 12:47 ` Linus Walleij
2011-05-25 12:23 ` Koul, Vinod
2011-05-26 7:36 ` Russell King - ARM Linux
2011-05-26 12:25 ` Koul, Vinod
2011-05-26 13:38 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110526133858.GI24876@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).