From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/4] Consolidate sdhci pltfm & OF drivers and get them self registered
Date: Fri, 27 May 2011 01:26:47 -0600 [thread overview]
Message-ID: <20110527072647.GE31953@ponder.secretlab.ca> (raw)
In-Reply-To: <1306321314-2493-1-git-send-email-shawn.guo@linaro.org>
On Wed, May 25, 2011 at 07:01:50PM +0800, Shawn Guo wrote:
> Here are what the patch set does.
>
> * Remove .probe and .remove hooks from sdhci-pltfm.c and make it be
> a pure common helper function providers.
> * Add .probe and .remove hooks for sdhci pltfm drivers sdhci-cns3xxx,
> sdhci-dove, sdhci-tegra, and sdhci-esdhc-imx to make them self
> registered with calling helper functions created above.
> * Migrate the use of sdhci_of_host and sdhci_of_data to
> sdhci_pltfm_host and sdhci_pltfm_data, so that OF version host and
> data structure works can be saved, and pltfm version works for both
> cases.
> * Add OF common helper stuff into sdhci-pltfm.c, and make OF version
> sdhci drivers sdhci-of-esdhc and sdhci-of-hlwd become self
> registered as well, so that sdhci-of-core.c and sdhci-of.h can be
> removed.
> * Eliminate include/linux/mmc/sdhci-pltfm.h with moving stuff into
> drivers/mmc/host/sdhci-pltfm.h.
>
> And the benefits we gain from the changes are:
>
> * Get the sdhci device driver follow the Linux trend that driver
> makes the registration by its own.
> * sdhci-pltfm.c becomes simple and clean as it only has common helper
> stuff there now.
> * All sdhci device specific things are going back its own driver.
> * The dt and non-dt drivers are consolidated to use the same pair of
> .probe and .remove hooks.
Hey Chris,
Any chance we can get this series into $NEXT_KERNEL?
Thanks,
g.
>
> Changes since v2:
> * Drop imx mpc esdhc consolidation
> * Fix checkpatch errors
> * Add sdhci-of-core.c copyright into sdhci-pltfm.c
>
> Changes since v1:
> * Rebase on cjb's mmc-next tree
> * Introduce helper function pair sdhci_pltfm_register and
> sdhci_pltfm_unregister
> * Eliminate variable 'scratch' in .remove hook to make the code
> look simple
> * Return ERR_PTR in sdhci_pltfm_init and use IS_ERR/PTR_ERR to check
> return value in .probe hooks
> * Correct MODULE_AUTHOR statement
> * Split esdhc conlidation patch to ease reviewing
>
> Shawn Guo (4):
> mmc: sdhci: make sdhci-pltfm device drivers self registered
> mmc: sdhci: eliminate sdhci_of_host and sdhci_of_data
> mmc: sdhci: make sdhci-of device drivers self registered
> mmc: sdhci: merge two sdhci-pltfm.h into one
>
> drivers/mmc/host/Kconfig | 47 +++----
> drivers/mmc/host/Makefile | 18 +--
> drivers/mmc/host/sdhci-cns3xxx.c | 43 ++++++-
> drivers/mmc/host/sdhci-dove.c | 42 ++++++-
> drivers/mmc/host/sdhci-esdhc-imx.c | 114 +++++++++++-----
> drivers/mmc/host/sdhci-of-core.c | 250 ---------------------------------
> drivers/mmc/host/sdhci-of-esdhc.c | 85 +++++++++---
> drivers/mmc/host/sdhci-of-hlwd.c | 66 ++++++++--
> drivers/mmc/host/sdhci-of.h | 42 ------
> drivers/mmc/host/sdhci-pltfm.c | 266 ++++++++++++++++++++----------------
> drivers/mmc/host/sdhci-pltfm.h | 39 +++++-
> drivers/mmc/host/sdhci-tegra.c | 116 +++++++++++-----
> include/linux/mmc/sdhci-pltfm.h | 35 -----
> 13 files changed, 578 insertions(+), 585 deletions(-)
>
> Regards,
> Shawn
>
next prev parent reply other threads:[~2011-05-27 7:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 11:01 [PATCH v3 0/4] Consolidate sdhci pltfm & OF drivers and get them self registered Shawn Guo
2011-05-25 11:01 ` [PATCH v3 1/4] mmc: sdhci: make sdhci-pltfm device drivers " Shawn Guo
2011-05-25 11:01 ` [PATCH v3 2/4] mmc: sdhci: eliminate sdhci_of_host and sdhci_of_data Shawn Guo
2011-05-25 11:01 ` [PATCH v3 3/4] mmc: sdhci: make sdhci-of device drivers self registered Shawn Guo
2011-05-25 11:01 ` [PATCH v3 4/4] mmc: sdhci: merge two sdhci-pltfm.h into one Shawn Guo
2011-05-27 7:26 ` Grant Likely [this message]
2011-05-27 8:06 ` [PATCH v3 0/4] Consolidate sdhci pltfm & OF drivers and get them self registered Wolfram Sang
2011-05-27 9:07 ` Shawn Guo
2011-05-27 16:06 ` Chris Ball
2011-05-27 20:29 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110527072647.GE31953@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).