From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: IrDA driver fails on PXA255
Date: Sun, 29 May 2011 22:58:05 +0100 [thread overview]
Message-ID: <20110529215805.GB5576@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.00.1105291417090.9658@chino.kir.corp.google.com>
On Sun, May 29, 2011 at 02:19:40PM -0700, David Rientjes wrote:
> On Sun, 29 May 2011, Russell King - ARM Linux wrote:
>
> > > arm, pxa2xx: enable DMA support for pxa2xx IRDA interface
> > >
> > > The pxa2xx-ir driver allocates with GFP_DMA, so it must always have
> > > ZONE_DMA.
> >
> > Wrong way. If there's no restrictions, drivers shouldn't be using
> > GFP_DMA. For the majority of SoCs, that's the case.
> >
>
> That's great, but before you can actually determine what requires DMA for
> this driver and what doesn't, we need something for this merge window (and
> backported to -stable) so that users aren't forced to go through and
> enable CONFIG_ZONE_DMA on their own .config.
>
> Is there a downside to enabling CONFIG_ZONE_DMA for all configs that
> compile this driver until a better solution can be found?
We might as well enable CONFIG_ZONE_DMA for everything if that's what
you're proposing, because it's not just this driver which will be affected.
And as soon as we do that, we completely lose the warnings that stuff
needs fixing.
This is not the way to sort this problem out.
next prev parent reply other threads:[~2011-05-29 21:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-28 20:57 IrDA driver fails on PXA255 Dmitry Eremin-Solenikov
2011-05-28 23:34 ` David Rientjes
2011-05-28 23:46 ` Russell King - ARM Linux
2011-05-29 2:22 ` David Rientjes
2011-05-29 7:25 ` Russell King - ARM Linux
2011-05-29 21:19 ` David Rientjes
2011-05-29 21:58 ` Russell King - ARM Linux [this message]
2011-05-31 5:01 ` David Rientjes
2011-05-29 8:36 ` Dmitry Eremin-Solenikov
2011-05-29 21:17 ` David Rientjes
2011-05-29 21:33 ` Dmitry Eremin-Solenikov
2011-05-29 21:56 ` Russell King - ARM Linux
2011-05-31 5:05 ` David Rientjes
2011-05-31 7:26 ` Russell King - ARM Linux
2011-05-31 20:03 ` David Rientjes
2011-05-31 21:00 ` Russell King - ARM Linux
2011-05-31 22:11 ` David Rientjes
2011-06-01 7:54 ` Russell King - ARM Linux
2011-06-01 15:50 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110529215805.GB5576@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).