From mboxrd@z Thu Jan 1 00:00:00 1970 From: arnd@arndb.de (Arnd Bergmann) Date: Mon, 30 May 2011 12:29:21 +0200 Subject: [PATCH] Consolidate the clkdev header files In-Reply-To: <20110530010416.GA24365@july> References: <20110530010416.GA24365@july> Message-ID: <201105301229.21973.arnd@arndb.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Monday 30 May 2011, Kyungmin Park wrote: > From: Kyungmin Park > > Now most of ARM machines has the alsmot same __clk_get/put() macro > > So place it at the arch/arm/include/asm/clkdev.h and remove the reduntant header files > > But some machines don't have the same form as above. It can use the machince specific clkdev file by HAVE_MACH_CLKDEV config > > Now there are only 3 caese. > > 1) define the clk structure with clkdev macro => Need to move clk structure to proper header file > > arch/arm/mach-versatile/include/mach/clkdev.h > arch/arm/mach-realview/include/mach/clkdev.h > arch/arm/mach-vexpress/include/mach/clkdev.h > arch/arm/mach-integrator/include/mach/clkdev.h > > 2) export the __clk_get/put function at clock.c > > arch/arm/mach-shmobile/include/mach/clkdev.h > > 3) demuxing the clk source > arch/arm/mach-u300/include/mach/clkdev.h > > Signed-off-by: Kyungmin Park This looks like a very useful simplification by itself, nice work! You definitely need to coordinate this with the struct clk consolidation that Jeremy Kerr has just posted though. It seems that you are touching some of the same code lines. Arnd