From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Xilinx: Adding zynq platform support
Date: Mon, 30 May 2011 14:20:56 -0600 [thread overview]
Message-ID: <20110530202056.GB32035@ponder.secretlab.ca> (raw)
In-Reply-To: <20110526222512.GO24876@n2100.arm.linux.org.uk>
On Thu, May 26, 2011 at 11:25:12PM +0100, Russell King - ARM Linux wrote:
> On Thu, May 26, 2011 at 04:16:10PM -0600, Grant Likely wrote:
> > Will you pick up the zynq patch also?
>
> It's about 1000 new lines, and I'm not sure Linus will take that
> level of addition - certainly not without explanation.
>
> Also, if we adhere to the policy that we don't introduce new code
> which should be using the consolidated code which we've already
> introduced, this would need to be updated to use the mmio
> clocksource stuff at the very least.
>
> I'm also not convinced that this platform would have the ICST PLL
> chips on it, so why it needs to select ICST I'm not sure (as well
> as having the PLL parameters in its struct clk.)
This is because it is reusing some of the versatile struct clk
implementation instead of cloning it's own set of plat-zynq stuff. I
recommended to John to not create a completely new struct clk, and
that Versatile was probable the most generic of the lot.
g.
next prev parent reply other threads:[~2011-05-30 20:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 15:50 [git pull] ARM Device tree support Grant Likely
2011-05-24 18:42 ` Nicolas Pitre
[not found] ` <BANLkTi=hCpCbNzi1ZiKmGnbhmCG2Ce=EkA@mail.gmail.com>
2011-05-26 13:59 ` [PATCH] ARM: Xilinx: Adding zynq platform support Arnd Bergmann
2011-05-26 15:06 ` Grant Likely
2011-05-26 22:01 ` Russell King - ARM Linux
2011-05-26 22:13 ` Grant Likely
2011-05-26 22:16 ` Grant Likely
2011-05-26 22:25 ` Russell King - ARM Linux
2011-05-30 20:20 ` Grant Likely [this message]
2011-05-30 9:47 ` Barry Song
2011-05-30 20:23 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110530202056.GB32035@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).