linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] mach-u300: fix compilation error in timer
@ 2011-05-30 14:08 Linus Walleij
  2011-05-30 21:51 ` Russell King - ARM Linux
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2011-05-30 14:08 UTC (permalink / raw)
  To: linux-arm-kernel

From: Linus Walleij <linus.walleij@linaro.org>

The introduction of the mmio timer accidentally referenced the
old clocksource struct which does not exist anymore. Fix this by
using a simple string instead. This also fixes a compilation
warning by casting the address to (void __iomem *).

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 arch/arm/mach-u300/timer.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-u300/timer.c b/arch/arm/mach-u300/timer.c
index 891cf44..5e886a4 100644
--- a/arch/arm/mach-u300/timer.c
+++ b/arch/arm/mach-u300/timer.c
@@ -409,10 +409,10 @@ static void __init u300_timer_init(void)
 		U300_TIMER_APP_VBASE + U300_TIMER_APP_EGPT2);
 
 	/* Use general purpose timer 2 as clock source */
-	if (clocksource_mmio_init(U300_TIMER_APP_VBASE + U300_TIMER_APP_GPT2CC,
+	if (clocksource_mmio_init((void __iomem *)
+				  U300_TIMER_APP_VBASE + U300_TIMER_APP_GPT2CC,
 			"GPT2", rate, 300, 32, clocksource_mmio_readl_up))
-		printk(KERN_ERR "timer: failed to initialize clock "
-		       "source %s\n", clocksource_u300_1mhz.name);
+		pr_err("timer: failed to initialize U300 clock source\n");
 
 	clockevents_calc_mult_shift(&clockevent_u300_1mhz,
 				    rate, APPTIMER_MIN_RANGE);
-- 
1.7.3.2

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH 1/2] mach-u300: fix compilation error in timer
  2011-05-30 14:08 [PATCH 1/2] mach-u300: fix compilation error in timer Linus Walleij
@ 2011-05-30 21:51 ` Russell King - ARM Linux
  0 siblings, 0 replies; 2+ messages in thread
From: Russell King - ARM Linux @ 2011-05-30 21:51 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, May 30, 2011 at 04:08:11PM +0200, Linus Walleij wrote:
> From: Linus Walleij <linus.walleij@linaro.org>
> 
> The introduction of the mmio timer accidentally referenced the
> old clocksource struct which does not exist anymore. Fix this by
> using a simple string instead. This also fixes a compilation
> warning by casting the address to (void __iomem *).

Please fix your #defines for IOMEM addresses instead of adding
explicit casts where its used.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-05-30 21:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-05-30 14:08 [PATCH 1/2] mach-u300: fix compilation error in timer Linus Walleij
2011-05-30 21:51 ` Russell King - ARM Linux

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).