linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC 2/2] ARM:Tegra: Device Tree Support: Initialize audio card gpio's from the device tree.
Date: Tue, 31 May 2011 11:24:08 +0100	[thread overview]
Message-ID: <20110531102407.GD7067@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20110530234909.GA3411@quad.lixom.net>

On Mon, May 30, 2011 at 04:49:09PM -0700, Olof Johansson wrote:

> What I was not sure about was the use of having an array of unnamed
> gpios as part of the consumer-side binding, where there's no logical
> ordering between these entries.

> In the sdhci case, there are three gpios; one to supply power to the slot;
> one for card detect and one for write protect sense.

> In that case, it would make a whole lot more sense to have three separate
> properties, say "power-gpio", "cd-gpio" and "wp-gpio", than an opaque array of
> entries without description besides what comments are used in the dts file.

> That these in turn point just to gpio number <x> at controller <y> is OK with
> me. Also, I can see cases where it makes sense to have more than one gpio
> references in a property (i.e. busses), but only where there's either internal
> ordering to them, or where ordering doesn't matter at all.

I agree strongly with this - there's a very good reason why this is the
existing pattern for platform data.  There's other cases that are even
worse than SDHCI where you can get a large number of potential outputs
from a device that could be wired up, a vanishingly small number
(possibly even none) of which will actually be used in a given system.

  parent reply	other threads:[~2011-05-31 10:24 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-27 20:56 [RFC 0/2] ARM: Tegra: Device Tree: Audio John Bonesio
     [not found] ` <20110527205721.21000.78599.stgit@riker>
2011-05-27 21:06   ` [RFC 2/2] ARM:Tegra: Device Tree Support: Initialize audio card gpio's from the device tree Grant Likely
2011-05-28  1:24   ` Mark Brown
2011-05-30  3:11     ` Olof Johansson
2011-05-30  3:38       ` Mark Brown
2011-05-30  6:11         ` Grant Likely
2011-05-30  6:18           ` Mitch Bradley
2011-05-30  6:22             ` Grant Likely
2011-05-30  7:01             ` Mark Brown
2011-05-30 16:22               ` Grant Likely
2011-05-30 18:54               ` Segher Boessenkool
2011-05-30 19:20                 ` Grant Likely
2011-05-30 20:53                   ` Mitch Bradley
2011-05-31 17:55                     ` Stephen Warren
2011-05-31 18:42                       ` Mitch Bradley
2011-06-01 15:59                         ` Stephen Warren
2011-06-01 16:18                           ` Mark Brown
2011-06-02 15:40                             ` Grant Likely
2011-06-01 21:32                           ` Mitch Bradley
2011-06-03 21:24                             ` Stephen Warren
2011-06-04  0:25                               ` Mitch Bradley
2011-06-02 14:59                       ` Grant Likely
2011-06-02 15:40                     ` Grant Likely
2011-06-28 21:39                   ` Grant Likely
2011-05-30 23:27               ` Benjamin Herrenschmidt
2011-05-30 23:49                 ` Olof Johansson
2011-05-31  0:58                   ` Segher Boessenkool
2011-05-31 10:24                   ` Mark Brown [this message]
2011-05-30  7:10           ` Mark Brown
2011-05-30 23:26           ` Benjamin Herrenschmidt
2011-05-31 10:03             ` Mark Brown
     [not found] ` <20110527205706.21000.34832.stgit@riker>
2011-05-27 21:05   ` [RFC 1/2] ARM:Tegra: Device Tree Support: Initialize the audio card " Grant Likely
2011-05-28  1:28   ` Mark Brown
2011-06-01  7:07   ` Barry Song
2011-06-01 16:47     ` Grant Likely
2011-06-02  9:07       ` Barry Song
2011-06-02 16:04         ` Grant Likely
2011-06-02 16:21           ` Barry Song
2011-06-02 21:43             ` Russell King - ARM Linux
2011-06-03  2:32               ` Barry Song
2011-06-03  6:20                 ` Russell King - ARM Linux
2011-06-02 21:36           ` Russell King - ARM Linux
2011-06-03  1:19             ` Barry Song
2011-06-07  3:44               ` Barry Song
2011-06-14 15:42             ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110531102407.GD7067@opensource.wolfsonmicro.com \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).