Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: ming.lei@canonical.com (Ming Lei)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: fix lockdep warning of "unannotated irqs-off"
Date: Wed, 1 Jun 2011 22:28:29 +0800	[thread overview]
Message-ID: <20110601222829.6eaad0e6@tom-ThinkPad-T410> (raw)
In-Reply-To: <20110601132233.GG3660@n2100.arm.linux.org.uk>


Hi,

On Wed, 1 Jun 2011 14:22:33 +0100
Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:

> From: Russell King - ARM Linux <linux@arm.linux.org.uk>

> If CONFIG_IRQSOFF_TRACER is not set, we don't bother telling the
> tracer that we've turned IRQs on for userspace when we exit from the
> kernel, and we don't bother telling the tracer that we've turned IRQs
> off when entering from userspace back into the kernel.
> 
> So, making this depend on CONFIG_TRACE_IRQFLAGS looks wrong to me.

>From lib/Kconfig.debug:

	config PROVE_LOCKING
		bool "Lock debugging: prove locking correctness"
		......
		select TRACE_IRQFLAGS

you can find locking prove does need to enable TRACE_IRQFLAGS. Meantime,
we may not enable irq off tracer via below:
	
	Kernel hacking  --->
		Tracers  --->
			[ ]   Interrupts-off Latency Tracer	

so making this depend on CONFIG_TRACE_IRQFLAGS is reasonable.

thanks,
--
Ming Lei

  reply	other threads:[~2011-06-01 14:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-01  7:42 [PATCH] arm: fix lockdep warning of "unannotated irqs-off" Ming Lei
2011-06-01  9:34 ` Russell King - ARM Linux
2011-06-01 13:17   ` Ming Lei
2011-06-01 13:22     ` Russell King - ARM Linux
2011-06-01 14:28       ` Ming Lei [this message]
2011-06-01 14:46         ` Russell King - ARM Linux
2011-06-01 15:52           ` Ming Lei
2011-06-01 16:01             ` Russell King - ARM Linux
2011-06-02  1:32               ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110601222829.6eaad0e6@tom-ThinkPad-T410 \
    --to=ming.lei@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox