From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 0/4] Move plat-mxc gpio driver into drivers/gpio
Date: Fri, 3 Jun 2011 08:52:01 +0100 [thread overview]
Message-ID: <20110603075201.GE10532@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1306985632-18820-1-git-send-email-shawn.guo@linaro.org>
On Thu, Jun 02, 2011 at 11:33:48AM +0800, Shawn Guo wrote:
> arch/arm/plat-mxc/gpio.c | 361 -------------------
> drivers/gpio/gpio-mxc.c | 433 +++++++++++++++++++++++
I'm wondering why just moving this driver into drivers/gpio has
resulted in it growing by 72 lines - and it's not clear from the
diffs why that is because of the way they're broken up.
Would it not be better to have the first patch to merely move
arch/arm/plat-mxc/gpio.c to drivers/gpio/gpio-mxc.c, making whatever
config changes are necessary. Then subsequent patches should change
drivers/gpio/gpio-mxc.c as required - which means we can see what
changes are being made.
As the series currently stands, from the review point of view it's
effectively adding an entirely new driver, converting everything over
to it, and then deleting the old.
next prev parent reply other threads:[~2011-06-03 7:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 3:33 [PATCH v2 0/4] Move plat-mxc gpio driver into drivers/gpio Shawn Guo
2011-06-02 3:33 ` [PATCH v2 1/4] gpio: gpio-mxc: add gpio driver for Freescale MXC architecture Shawn Guo
2011-06-02 5:24 ` Olof Johansson
2011-06-02 3:33 ` [PATCH v2 2/4] ARM: mxc: migrate mach-mx5 gpio driver to gpio-mxc Shawn Guo
2011-06-02 5:18 ` Olof Johansson
2011-06-02 3:33 ` [PATCH v2 3/4] ARM: mxc: migrate mach-imx " Shawn Guo
2011-06-02 5:19 ` Olof Johansson
2011-06-03 10:59 ` Philippe Rétornaz
2011-06-03 11:54 ` Fabio Estevam
2011-06-03 13:23 ` Arnd Bergmann
2011-06-02 3:33 ` [PATCH v2 4/4] ARM: mxc: remove plat-mxc/gpio driver Shawn Guo
2011-06-02 5:20 ` Olof Johansson
2011-06-03 7:52 ` Russell King - ARM Linux [this message]
2011-06-03 14:34 ` [PATCH v2 0/4] Move plat-mxc gpio driver into drivers/gpio Shawn Guo
2011-06-03 14:55 ` Grant Likely
2011-06-03 15:26 ` Shawn Guo
2011-06-03 15:47 ` Grant Likely
2011-06-03 15:48 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110603075201.GE10532@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).