linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix ioremap to allow mapping some specific RAM areas
Date: Tue, 7 Jun 2011 09:05:41 +0100	[thread overview]
Message-ID: <20110607080541.GA20929@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1307430745-17329-1-git-send-email-m.szyprowski@samsung.com>

On Tue, Jun 07, 2011 at 09:12:25AM +0200, Marek Szyprowski wrote:
> Creating more than one mapping on ARMv6+ might cause unspecified behavior,
> so ioremap() should fail if it was called with area that matches low memory.
> However if the board code removes the specific area from low memory
> mapping on boot (for example by calling memblock_remove()), then creating
> a mapping with ioremap might be desired.
> 
> This patch enables creating mapping for RAM by ioremap call, but only if
> the target area has no low memory mapping yet. This enables board code to
> reserve particular memory areas with memblock_remove() and provide them to
> device drivers with a declare_coherent_memory() call.

NAK.  pfn_valid is already defined like this:

int pfn_valid(unsigned long pfn)
{
        return memblock_is_memory(pfn << PAGE_SHIFT);
}

provided you enable ARCH_HAS_HOLES_MEMORYMODEL, which you must do if
you're punching holes in the memory map.

  reply	other threads:[~2011-06-07  8:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-07  7:12 [PATCH] ARM: fix ioremap to allow mapping some specific RAM areas Marek Szyprowski
2011-06-07  8:05 ` Russell King - ARM Linux [this message]
2011-06-07  8:44   ` Marek Szyprowski
2011-06-07  8:54     ` Russell King - ARM Linux
2011-06-07 10:49       ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110607080541.GA20929@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).