From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: fix ioremap to allow mapping some specific RAM areas
Date: Tue, 7 Jun 2011 09:54:46 +0100 [thread overview]
Message-ID: <20110607085446.GC20929@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <003c01cc24ef$151827b0$3f487710$%szyprowski@samsung.com>
On Tue, Jun 07, 2011 at 10:44:15AM +0200, Marek Szyprowski wrote:
> On Tuesday, June 07, 2011 10:06 AM Russell King - ARM Linux wrote:
> > NAK. pfn_valid is already defined like this:
> >
> > int pfn_valid(unsigned long pfn)
> > {
> > return memblock_is_memory(pfn << PAGE_SHIFT);
> > }
> >
> > provided you enable ARCH_HAS_HOLES_MEMORYMODEL, which you must do if
> > you're punching holes in the memory map.
>
> Ok, I see the point in ARCH_HAS_HOLES_MEMORYMODEL, but it doesn't solve my
> problem. In case of Samsung Exynos4 and S5PV210 platforms we use SPARSEMEM,
> but the above definition of pfn_valid() function is correct only if SPARSEMEM
> is not enabled.
Sparsemem has been fixed recently (during the merge window) so that this
is now correct.
next prev parent reply other threads:[~2011-06-07 8:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-07 7:12 [PATCH] ARM: fix ioremap to allow mapping some specific RAM areas Marek Szyprowski
2011-06-07 8:05 ` Russell King - ARM Linux
2011-06-07 8:44 ` Marek Szyprowski
2011-06-07 8:54 ` Russell King - ARM Linux [this message]
2011-06-07 10:49 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110607085446.GC20929@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).