linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: pmu: refactor reservation
Date: Thu, 9 Jun 2011 10:55:47 +0100	[thread overview]
Message-ID: <20110609095547.GA3711@pulham.picochip.com> (raw)
In-Reply-To: <1307546911-2714-2-git-send-email-mark.rutland@arm.com>

On Wed, Jun 08, 2011 at 04:28:30PM +0100, Mark Rutland wrote:
> Currently, PMU platform_device reservation relies on some minor abuse
> of the platform_device::id field for determining the type of PMU. This
> is problematic for device tree based probing, where the ID cannot be
> controlled.
> 
> This patch removes reliance on the id field, and depends on each PMU's
> platform driver to figure out which type it is. As all PMUs handled by
> the current platform_driver name "arm-pmu" are CPU PMUs, this
> convention is hardcoded. New PMU types will require the addition of new
> platform drivers (e.g. "arm-pmu-l2cc").
> 
> Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> Acked-by: Will Deacon <will.deacon@arm.com>
> Cc: Jamie Iles <jamie@jamieiles.com>
> Cc: Rob Herring <rob.herring@calxeda.com>
> Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
> ---

Looks good to me.

Acked-by: Jamie Iles <jamie@jamieiles.com>

As a slight aside, when we have more PMU types could we key off of an ID 
table rather than creating a new platform driver for each type?

Jamie

  reply	other threads:[~2011-06-09  9:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08 15:28 [PATCH 0/2] ARM PMU reservation cleanup Mark Rutland
2011-06-08 15:28 ` [PATCH 1/2] ARM: pmu: refactor reservation Mark Rutland
2011-06-09  9:55   ` Jamie Iles [this message]
2011-06-08 15:28 ` [PATCH 2/2] ARM: pmu: reject duplicate PMU registrations Mark Rutland
2011-06-09  9:56   ` Jamie Iles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110609095547.GA3711@pulham.picochip.com \
    --to=jamie@jamieiles.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).