From: mika.westerberg@iki.fi (Mika Westerberg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/5] ep93xx: set DMA masks for the ep93xx_eth
Date: Thu, 9 Jun 2011 23:41:13 +0300 [thread overview]
Message-ID: <20110609204113.GE2857@acer> (raw)
In-Reply-To: <ADE657CA350FB648AAC2C43247A983F001F3820B85F3@AUSP01VMBX24.collaborationhost.net>
On Thu, Jun 09, 2011 at 03:27:11PM -0500, H Hartley Sweeten wrote:
> On Thursday, June 02, 2011 12:00 PM, Mika Westerberg wrote:
> >
> > As the driver is now passing platform device to the DMA mapping functions,
> > we should give it valid DMA masks.
> >
> > Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
> > Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Since you made this patch the first in the series the commit message is not
> quite right. Other than that:
>
> Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Ah, right. I forgot to change the commit message. How about following?
From: Mika Westerberg <mika.westerberg@iki.fi>
Subject: [PATCH 1/5] ep93xx: set DMA masks for the ep93xx_eth
Since the driver uses the DMA API, we should pass it valid DMA masks.
Signed-off-by: Mika Westerberg <mika.westerberg@iki.fi>
Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
Acked-by: H Hartley Sweeten <hsweeten@visionengravers.com>
---
arch/arm/mach-ep93xx/core.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-ep93xx/core.c b/arch/arm/mach-ep93xx/core.c
index 8207954..1d4b65f 100644
--- a/arch/arm/mach-ep93xx/core.c
+++ b/arch/arm/mach-ep93xx/core.c
@@ -402,11 +402,15 @@ static struct resource ep93xx_eth_resource[] = {
}
};
+static u64 ep93xx_eth_dma_mask = DMA_BIT_MASK(32);
+
static struct platform_device ep93xx_eth_device = {
.name = "ep93xx-eth",
.id = -1,
.dev = {
- .platform_data = &ep93xx_eth_data,
+ .platform_data = &ep93xx_eth_data,
+ .coherent_dma_mask = DMA_BIT_MASK(32),
+ .dma_mask = &ep93xx_eth_dma_mask,
},
.num_resources = ARRAY_SIZE(ep93xx_eth_resource),
.resource = ep93xx_eth_resource,
--
1.7.4.4
next prev parent reply other threads:[~2011-06-09 20:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 18:59 [PATCH v2 1/5] ep93xx: set DMA masks for the ep93xx_eth Mika Westerberg
2011-06-02 18:59 ` [PATCH v2 2/5] net: ep93xx_eth: pass struct device to DMA API functions Mika Westerberg
2011-06-09 20:41 ` H Hartley Sweeten
2011-06-09 23:40 ` H Hartley Sweeten
2011-06-10 16:55 ` Mika Westerberg
2011-06-10 17:30 ` H Hartley Sweeten
2011-06-02 18:59 ` [PATCH v2 3/5] net: ep93xx_eth: allocate buffers using kmalloc() Mika Westerberg
2011-06-09 20:53 ` H Hartley Sweeten
2011-06-02 18:59 ` [PATCH v2 4/5] net: ep93xx_eth: drop GFP_DMA from call to dma_alloc_coherent() Mika Westerberg
2011-06-09 20:59 ` H Hartley Sweeten
2011-06-02 18:59 ` [PATCH v2 5/5] net: ep93xx_eth: fix DMA API violations Mika Westerberg
2011-06-09 21:25 ` H Hartley Sweeten
2011-06-05 8:34 ` [PATCH v2 1/5] ep93xx: set DMA masks for the ep93xx_eth Petr Štetiar
2011-06-05 8:59 ` Mika Westerberg
2011-06-05 9:10 ` Petr Štetiar
2011-06-05 21:08 ` David Miller
2011-06-06 17:26 ` Mika Westerberg
2011-06-06 17:48 ` H Hartley Sweeten
2011-06-09 19:50 ` Mika Westerberg
2011-06-09 20:18 ` H Hartley Sweeten
2011-06-09 20:23 ` Mika Westerberg
2011-06-15 10:21 ` Lennert Buytenhek
2011-06-10 15:47 ` Petr Štetiar
2011-06-10 16:56 ` Mika Westerberg
2011-06-09 20:27 ` H Hartley Sweeten
2011-06-09 20:41 ` Mika Westerberg [this message]
2011-06-09 21:26 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110609204113.GE2857@acer \
--to=mika.westerberg@iki.fi \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).