From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/4] dt: add EXPORT_SYMBOL to of_platform_populate
Date: Fri, 10 Jun 2011 17:12:24 -0600 [thread overview]
Message-ID: <20110610231224.GH28994@ponder.secretlab.ca> (raw)
In-Reply-To: <4DF29E5F.8030307@gmail.com>
On Fri, Jun 10, 2011 at 05:44:47PM -0500, Rob Herring wrote:
> On 06/10/2011 04:37 PM, Grant Likely wrote:
> >On Fri, Jun 10, 2011 at 03:48:41PM -0500, Rob Herring wrote:
> >>From: Rob Herring<rob.herring@calxeda.com>
> >>
> >>of_platform_populate is missing an EXPORT_SYMBOL, so add it.
> >>
> >>Cc: Grant Likely<grant.likely@secretlab.ca>
> >>Signed-off-by: Rob Herring<rob.herring@calxeda.com>
> >>---
> >> drivers/of/platform.c | 1 +
> >> 1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >>diff --git a/drivers/of/platform.c b/drivers/of/platform.c
> >>index dc56a77..8d0f477 100644
> >>--- a/drivers/of/platform.c
> >>+++ b/drivers/of/platform.c
> >>@@ -328,4 +328,5 @@ int of_platform_populate(struct device_node *root,
> >> of_node_put(root);
> >> return rc;
> >> }
> >>+EXPORT_SYMBOL(of_platform_populate);
> >
> >I hadn't done this because I hadn't seen a need for calling it from
> >module code. Do you have a driver that uses it?
> >
>
> No, but then it doesn't appear that other functions in this file are
> used by modules either. Only of_platform_device_create is used by a
> module (drivers/macintosh) AFAICT.
>
> Either way, it doesn't really matter to me.
Okay, let's leave this out for the time being. It is a trivial patch
to add if someone needs it.
g.
next prev parent reply other threads:[~2011-06-10 23:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 20:48 [PATCH v4 0/4] amba bus devicetree probing Rob Herring
2011-06-10 20:48 ` [PATCH v4 1/4] dt: check root nodes for match on of_platform_populate Rob Herring
2011-06-10 21:06 ` Arnd Bergmann
2011-06-10 21:11 ` Grant Likely
2011-06-10 21:17 ` Arnd Bergmann
2011-06-10 21:13 ` Grant Likely
2011-06-10 20:48 ` [PATCH v4 2/4] dt: add EXPORT_SYMBOL to of_platform_populate Rob Herring
2011-06-10 21:37 ` Grant Likely
2011-06-10 22:44 ` Rob Herring
2011-06-10 23:12 ` Grant Likely [this message]
2011-06-10 20:48 ` [PATCH v4 3/4] drivers/amba: create devices from device tree Rob Herring
2011-06-10 21:04 ` Arnd Bergmann
2011-06-10 22:30 ` Grant Likely
2011-06-10 22:22 ` Grant Likely
2011-06-10 22:37 ` Rob Herring
2011-06-10 23:11 ` Grant Likely
2011-06-10 20:48 ` [PATCH v4 4/4] dt: add amba device creation to platform bus scan Rob Herring
2011-06-10 21:02 ` Arnd Bergmann
2011-06-10 22:39 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110610231224.GH28994@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).