From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/6] arm: footbridge: convert old leds event driver to led gpio trigger driver of Netwinder
Date: Mon, 13 Jun 2011 09:23:01 +0100 [thread overview]
Message-ID: <20110613082301.GB9393@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1307947185-5159-6-git-send-email-bryan.wu@canonical.com>
On Mon, Jun 13, 2011 at 02:39:44PM +0800, Bryan Wu wrote:
> +/* LEDs */
> +static struct gpio_led nw_gpio_leds[] = {
> + {
> + .name = "netwinder::led_red",
> + .default_trigger = "heartbeat",
> + .gpio = GPIO_RED_LED,
> + },
> + {
> + .name = "netwinder::led_green",
> + .default_trigger = "timer",
> + .gpio = GPIO_GREEN_LED,
> + },
This is especially broken. This platform has no GPIO support other
than its private stuff, which makes the use of the GPIO LED driver
useless. The GPIO_*_LED constants are bitmasks for the CPLD
controller.
next prev parent reply other threads:[~2011-06-13 8:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 6:39 [PATCH 0/6] footbridge consolidation patches Bryan Wu
2011-06-13 6:39 ` [PATCH 1/6] arm: footbridge: consolidation code of CATS machine Bryan Wu
2011-06-13 6:39 ` [PATCH 2/6] arm: footbridge: consolidation code of EBSA285 machine Bryan Wu
2011-06-13 6:39 ` [PATCH 3/6] arm: footbridge: consolidation code of Netwinder machine Bryan Wu
2011-06-13 6:39 ` [PATCH 4/6] arm: footbridge: consolidation code of Compaq Personal Server Bryan Wu
2011-06-13 6:39 ` [PATCH 5/6] arm: footbridge: convert old leds event driver to led gpio trigger driver of Netwinder Bryan Wu
2011-06-13 8:23 ` Russell King - ARM Linux [this message]
2011-06-13 10:02 ` Bryan Wu
2011-06-13 6:39 ` [PATCH 6/6] arm: footbridge: convert old leds event driver to led trigger drivers of EBSA285 Bryan Wu
2011-06-13 8:20 ` [PATCH 0/6] footbridge consolidation patches Russell King - ARM Linux
2011-06-13 9:57 ` Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110613082301.GB9393@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).