From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] gpio/74x164: fix clash with gpiolib namespace
Date: Mon, 13 Jun 2011 09:04:16 -0600 [thread overview]
Message-ID: <20110613150416.GC18161@ponder.secretlab.ca> (raw)
In-Reply-To: <1307954835-20812-1-git-send-email-linus.walleij@stericsson.com>
On Mon, Jun 13, 2011 at 10:47:15AM +0200, Linus Walleij wrote:
> The 74x164 GPIO driver has a static inline helper called
> gpio_to_chip which clashes with the gpiolib namespace if we
> try to expose the function with the same name from gpiolib,
> and it's still confusing even if we don't do that. So rename
> it to gpio_to_74x164_chip().
>
> Reported-by: H Hartley Sweeten <hartleys@visionengravers.com>
> Signed-off-by: Linus Walleij <linus.walleij@stericsson.com>
Merged, thanks.
g.
> ---
> drivers/gpio/gpio-74x164.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-74x164.c b/drivers/gpio/gpio-74x164.c
> index 7fb60b6..ff525c0 100644
> --- a/drivers/gpio/gpio-74x164.c
> +++ b/drivers/gpio/gpio-74x164.c
> @@ -23,7 +23,7 @@ struct gen_74x164_chip {
> u8 port_config;
> };
>
> -static struct gen_74x164_chip *gpio_to_chip(struct gpio_chip *gc)
> +static struct gen_74x164_chip *gpio_to_74x164_chip(struct gpio_chip *gc)
> {
> return container_of(gc, struct gen_74x164_chip, gpio_chip);
> }
> @@ -36,7 +36,7 @@ static int __gen_74x164_write_config(struct gen_74x164_chip *chip)
>
> static int gen_74x164_get_value(struct gpio_chip *gc, unsigned offset)
> {
> - struct gen_74x164_chip *chip = gpio_to_chip(gc);
> + struct gen_74x164_chip *chip = gpio_to_74x164_chip(gc);
> int ret;
>
> mutex_lock(&chip->lock);
> @@ -49,7 +49,7 @@ static int gen_74x164_get_value(struct gpio_chip *gc, unsigned offset)
> static void gen_74x164_set_value(struct gpio_chip *gc,
> unsigned offset, int val)
> {
> - struct gen_74x164_chip *chip = gpio_to_chip(gc);
> + struct gen_74x164_chip *chip = gpio_to_74x164_chip(gc);
>
> mutex_lock(&chip->lock);
> if (val)
> --
> 1.7.3.2
>
prev parent reply other threads:[~2011-06-13 15:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 8:47 [PATCH] gpio/74x164: fix clash with gpiolib namespace Linus Walleij
2011-06-13 15:04 ` Grant Likely [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110613150416.GC18161@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).