From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] mmc: sdhci: fix interrupt storm from card detection
Date: Tue, 14 Jun 2011 14:02:58 +0200 [thread overview]
Message-ID: <20110614120258.GE5043@pengutronix.de> (raw)
In-Reply-To: <20110614115557.GF30295@S2100-06.ap.freescale.net>
> > > The issue was initially found by Eric Benard as below.
> > >
> > > http://permalink.gmane.org/gmane.linux.ports.arm.kernel/108031
> > >
> > > Not sure about other SDHCI based controller, but on Freescale eSDHC,
> > > the SDHCI_INT_CARD_INSERT bits will be immediately set again when it
> > > gets cleared, if a card is inserted. The driver need to mask the irq
> > > to prevent interrupt storm which will freeze the system. And the
> > > SDHCI_INT_CARD_REMOVE gets the same situation.
> > >
> > > The patch fixes the problem based on the initial idea from
> > > Eric Benard.
> > >
> > > Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
> > > Cc: Eric Benard <eric@eukrea.com>
> >
> > Hmm, that should get enough testing on non-imx (and even non-ARM)
> > devices. And a comment describing the situation.
> >
> Agreed. Will add something in commit message to mention the
> situation. That's why I hope we can get the patch on mmc-next at
I actually meant a comment in the code, so it will be obvious for later
hackers why the "extra" steps are in there...
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110614/3e3c9a65/attachment.sig>
next prev parent reply other threads:[~2011-06-14 12:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 10:42 [PATCH 0/4] Extend sdhci-esdhc-imx card_detect and write_protect support for mx5 Shawn Guo
2011-06-10 10:42 ` [PATCH 1/4] mmc: sdhci: fix interrupt storm from card detection Shawn Guo
2011-06-14 9:24 ` Wolfram Sang
2011-06-14 11:55 ` Shawn Guo
2011-06-14 12:02 ` Wolfram Sang [this message]
2011-06-14 12:24 ` Shawn Guo
2011-06-10 10:42 ` [PATCH 2/4] mmc: sdhci-esdhc-imx: SDHCI_CARD_PRESENT does not get cleared Shawn Guo
2011-06-14 9:22 ` Wolfram Sang
2011-06-10 10:42 ` [PATCH 3/4] mmc: sdhci-esdhc-imx: remove "WP" from flag ESDHC_FLAG_GPIO_FOR_CD_WP Shawn Guo
2011-06-14 9:28 ` Wolfram Sang
2011-06-14 11:51 ` Shawn Guo
2011-06-10 10:42 ` [PATCH 4/4] mmc: sdhci-esdhc-imx: extend card_detect and write_protect support Shawn Guo
2011-06-11 9:30 ` Arnaud Patard (Rtp)
2011-06-11 11:50 ` Shawn Guo
2011-06-11 11:59 ` Arnaud Patard (Rtp)
2011-06-11 13:16 ` Shawn Guo
2011-06-11 19:21 ` Arnaud Patard (Rtp)
2011-06-14 6:47 ` [PATCH v2 4/4] mmc: sdhci-esdhc-imx: extend card_detect and write_protect support for mx5 Shawn Guo
2011-06-14 9:51 ` Wolfram Sang
2011-06-14 13:06 ` Shawn Guo
2011-06-14 13:55 ` Wolfram Sang
2011-06-15 3:10 ` Shawn Guo
2011-06-15 10:33 ` Shawn Guo
2011-06-15 10:44 ` Wolfram Sang
2011-06-14 6:48 ` [PATCH 0/4] Extend sdhci-esdhc-imx " Shawn Guo
2011-06-14 11:13 ` Arnaud Patard (Rtp)
2011-06-14 11:39 ` Shawn Guo
2011-06-14 13:12 ` Shawn Guo
2011-06-14 14:29 ` Arnaud Patard (Rtp)
2011-06-15 3:13 ` Shawn Guo
2011-06-16 18:32 ` Arnaud Patard (Rtp)
2011-06-20 10:41 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110614120258.GE5043@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).