linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: GPIO vs. other drivers order
Date: Wed, 15 Jun 2011 13:06:30 +0100	[thread overview]
Message-ID: <20110615120629.GC24628@pulham.picochip.com> (raw)
In-Reply-To: <ita6o6$od6$1@dough.gmane.org>

Hi Dmitry,

On Wed, Jun 15, 2011 at 11:57:58AM +0000, Dmitry Eremin-Solenikov wrote:
> Hello, colleagues,
> 
> I'm currently looking at cleaning up LoCoMo and Scoop2 drivers (custom
> Sharp ASICs used by Sharp Zaurus PDAs). One of the problems I'm stuck at
> is about GPIO parts of that chips: there are plenty of other devices
> depending on GPIO pins working correctly (ranging from board code
> itself up to several other sub-drivers).
> 
> What would be the better approach: to create a basic-mmio-gpio node (and
> hope for the order of initialization to be correct) or embed bgpio into
> main driver and call all necessary hooks directly from it?

Currently the basic-mmio-gpio platform driver is registed with a 
module_initcall so this may be too late for any machines that need GPIO 
in their .init_machine callback.  Moving the registration to a 
postcore_initcall (as OMAP does) and I don't recall seeing any 
objections to this.

If the basic-mmio-gpio driver does everything you need then registering 
it as a platform_device would be fine imho.  If you need to add/override 
some of the generic functionallity then embedding the bgpio_chip into 
your own structure is the probably best way to go.

Jamie

  reply	other threads:[~2011-06-15 12:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-15 11:57 GPIO vs. other drivers order Dmitry Eremin-Solenikov
2011-06-15 12:06 ` Jamie Iles [this message]
2011-06-15 12:18   ` Dmitry Eremin-Solenikov
2011-06-15 12:31     ` Jamie Iles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110615120629.GC24628@pulham.picochip.com \
    --to=jamie@jamieiles.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).