linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [MPCore Watchdog]: Convert from misc_dev to dynamic device node.
Date: Wed, 15 Jun 2011 20:09:45 +0100	[thread overview]
Message-ID: <20110615190945.GA2518@pulham.picochip.com> (raw)
In-Reply-To: <BANLkTinY8bM0PyLLcu6icEsWT=X=KVV3DQ@mail.gmail.com>

On Wed, Jun 15, 2011 at 11:57:12AM -0700, Peter Fordham wrote:
> > I've added Wim (watchdog driver maintainer), but I would think that if
> > this change is worth doing then it should be done for all drivers.
> 
> Agreed, but today this may be more work than I'm strictly interested in
> doing. If we do decide it's the right thing then I'll look into converting the
> other drivers later.

So I'm not fully aware of what particular problem this is solving, but 
if it is needed for this driver then it should really be done for all of 
them.  That's probably one for Wim to answer though.  Wim posted a 
series for a generic watchdog framework a while back[1] but this still 
made use of a misc device.

> >> > I believe the sysfs classes are pretty much
> >> > deprecated now in preference of a bus too.
> >>
> >> Can you give me some more info here? I thought the sysfs stuff was the
> >> new right way of doing stuff. The class stuff allows udev to automatically
> >> create the right device node.
> >
> > So here's one that I'm aware of https://lkml.org/lkml/2011/3/25/502. ?So
> > there's nothing wrong with using sysfs and a bus, but certainly a bus is
> > preferred over a class.
> 
> I still don't really get this. If I don't use the class code my /dev node gets
> the name /dev/mpcore_wdt instaed of /dev/watchdog. Is the right thing
> to do to use a udev rule or is there a way to tell udev via sysfs to make
> /dev/watchdog instead of /dev/mpcore_wdt?

If you use a bus then the device creation is slightly more involved than 
with a class - create the bus, allocate the device and assign the 
bus_type then set the name with dev_set_name().  That should be enough 
for udev to work out the name of the device.

Jamie

1. http://www.spinics.net/lists/linux-watchdog/msg00082.html

  reply	other threads:[~2011-06-15 19:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 23:29 [MPCore Watchdog]: Convert from misc_dev to dynamic device node Peter Fordham
2011-06-14 23:48 ` Jamie Iles
2011-06-15  0:19   ` Peter Fordham
2011-06-15  8:58     ` Jamie Iles
2011-06-15 18:57       ` Peter Fordham
2011-06-15 19:09         ` Jamie Iles [this message]
2011-06-15 19:36           ` Peter Fordham
2011-06-15 19:37             ` Peter Fordham
2011-06-15 19:36           ` Arnd Bergmann
2011-06-15 19:49             ` Peter Fordham
2011-06-15 20:03               ` Arnd Bergmann
2011-06-17  7:20             ` Wim Van Sebroeck
2011-06-17  7:17         ` Wim Van Sebroeck
2011-06-17  7:14       ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110615190945.GA2518@pulham.picochip.com \
    --to=jamie@jamieiles.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).