From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 5/6] ARM: mxc: all three imx51 TOs use TO1 version of sdma script
Date: Thu, 16 Jun 2011 09:30:18 +0200 [thread overview]
Message-ID: <20110616073018.GF23771@pengutronix.de> (raw)
In-Reply-To: <20110615042948.GB31712@S2100-06.ap.freescale.net>
On Wed, Jun 15, 2011 at 12:29:49PM +0800, Shawn Guo wrote:
> On Tue, Jun 14, 2011 at 10:38:09PM +0200, Sascha Hauer wrote:
> > On Tue, Jun 14, 2011 at 02:20:07PM +0800, Shawn Guo wrote:
> > > Though there are three TOs of imx51 soc, the sdma script never
> > > changes since TO1, which means all three TOs of imx51 uses TO1
> > > version of sdma script.
> > >
> > > The current code passes TO number to imx-sdma driver to load
> > > different firmware for different TO. That means we have to prepare
> > > 3 identical firmwares, sdma-imx51-to1.bin sdma-imx51-to2.bin and
> > > sdma-imx51-to3.bin, to have the kernel capable of running on all
> > > three TOs. This just makes no sense.
> > >
> > > The patch removes the TO number passing and get the default TO1
> > > version of sdma firmware work for all TOs.
> >
> > I don't agree to this approach. The SDMA firmware has been different on
> > all TO versions of earlier i.MXs. For the linearity of the universe we
> > should keep this. What about providing a link in userspace?
> >
> The fact is that mx31 and mx35 are the only two SoCs (relatively old
> ones) that have different SDMA firmwares on different TOs. The
> relatively new ones, mx25 (TO1, TO1.1), mx50 (TO1, TO1.1), mx51
> (TO1, TO2, TO3) and mx53 (TO1, TO2) all have one version SDMA
> firmware for different TOs. I do not see the mx31/35 case is a
> linearity of the universe. Do we really want to bother ourselves
> with userspace link on so many latest SoCs?
Ok, then let's do it differently. Let's go away from "sdma-%s-to%d.bin"
in the sdma driver and pass the string from platform data instead.
Then we can pass the TO version where it's relevant and skip it where
only one firmware exists. Using a sdma-imx51-to1.bin for to2 and to3
is confusing.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2011-06-16 7:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 7:37 [PATCH 0/6] Some fixes and cleanup on imx-dma device registration Shawn Guo
2011-06-13 7:37 ` [PATCH 1/6] ARM: mxc: imx-sdma device gets 16K iosize than 4K Shawn Guo
2011-06-13 7:37 ` [PATCH 2/6] ARM: mxc: sdma on imx25 is a V2 block Shawn Guo
2011-06-13 7:37 ` [PATCH 3/6] ARM: mxc: change imx-dma default to_version to 1 Shawn Guo
2011-06-13 7:37 ` [PATCH 4/6] ARM: mxc: imx-dma on imx25 has no other TO version but TO1 Shawn Guo
2011-06-13 7:37 ` [PATCH 5/6] ARM: mxc: all three imx51 TOs use TO1 version of sdma script Shawn Guo
2011-06-13 12:36 ` Fabio Estevam
2011-06-13 13:05 ` Shawn Guo
2011-06-14 6:20 ` [PATCH v2 " Shawn Guo
2011-06-14 20:38 ` Sascha Hauer
2011-06-15 4:29 ` Shawn Guo
2011-06-16 7:30 ` Sascha Hauer [this message]
2011-06-16 11:51 ` Shawn Guo
2011-06-17 1:59 ` Fabio Estevam
2011-06-17 2:27 ` Shawn Guo
2011-06-20 7:20 ` Sascha Hauer
2011-06-13 7:37 ` [PATCH 6/6] ARM: mxc: clean up imx-dma device registration Shawn Guo
2011-06-20 14:50 ` Shawn Guo
2011-06-21 14:41 ` Shawn Guo
2011-06-21 15:13 ` Wolfram Sang
2011-06-22 2:43 ` Shawn Guo
2011-06-22 6:33 ` Wolfram Sang
2011-06-21 22:57 ` Sascha Hauer
2011-06-22 2:53 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110616073018.GF23771@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).