linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mach-imx/mx31_3ds: Fix IOMUX for SPI1 signals
Date: Mon, 20 Jun 2011 15:10:36 +0200	[thread overview]
Message-ID: <20110620131036.GT23771@pengutronix.de> (raw)
In-Reply-To: <BANLkTikeJ2vB1YW4+P0cgcLsAy7hP2Yc1w@mail.gmail.com>

On Mon, Jun 20, 2011 at 09:43:13AM -0300, Fabio Estevam wrote:
> Hi Sascha,
> 
> On Mon, Jun 20, 2011 at 4:26 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > On Thu, Jun 16, 2011 at 01:42:52PM -0300, Fabio Estevam wrote:
> >> The LCD on the mx31_3ds board is connected to CSPI1.
> >
> > From the description I would say you remove exactly the setup we want
> > instead of adding it. Can you explain a bit more?
> 
> Sure, the original code was assuming that the CSPI1 pins on the
> MX31PDK were the primary pin function, which is incorrect.
> 
> On MX31PDK board these are the pins that provide CSPI1 functionality:
> 
> DSR_DCE1 (ALT mode 1) --> CSPI1_CLK
> RI_DCE1 (ALT mode 1) --> CSPI1_RDY
> 
> DTR_DTE1  -->CSI1_MOSI
> DSR_DTE1 --> CSPI1_MISO
> DTR_DCE2 ---> CSPI1_SS2
> 
> The 3 IOMUX settings above are done via GPR as per Table A-1 of the MX31RM.
> 
> So the patch I sent fixes the CSPI1 IOMUX and makes the LCD to be functional.
> 
> I think we haven't seen this before because probably Redboot was doing
> the IOMUX for us. After I switched to U-boot I was not able to get the
> LCD to work and now with this patch it is working fine. FSL BSP also
> does the IOMUX in the same way.
> 
> If you prefer I can post a v2 of this patch with a better explanation
> on the commit message.
> 

Yes please.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

      reply	other threads:[~2011-06-20 13:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-16 16:42 [PATCH] ARM: mach-imx/mx31_3ds: Fix IOMUX for SPI1 signals Fabio Estevam
2011-06-20  7:26 ` Sascha Hauer
2011-06-20 12:43   ` Fabio Estevam
2011-06-20 13:10     ` Sascha Hauer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110620131036.GT23771@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).