From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: mach-imx/mx31_3ds: Fix IOMUX for SPI1 signals
Date: Tue, 21 Jun 2011 14:07:19 +0200 [thread overview]
Message-ID: <20110621120719.GY23771@pengutronix.de> (raw)
In-Reply-To: <1308577033-10678-1-git-send-email-fabio.estevam@freescale.com>
On Mon, Jun 20, 2011 at 10:37:13AM -0300, Fabio Estevam wrote:
> Original code was assuming that the CSPI1 pins on the
> MX31PDK were the primary pin function, which is incorrect.
>
> On MX31PDK board these are the pins that provide CSPI1 functionality:
>
> DSR_DCE1 (ALT mode 1) --> CSPI1_CLK
> RI_DCE1 (ALT mode 1) --> CSPI1_RDY
>
> DTR_DTE1 -->CSI1_MOSI
> DSR_DTE1 --> CSPI1_MISO
> DTR_DCE2 ---> CSPI1_SS2
>
> The 3 IOMUX settings above are done via GPR as per Table A-1 of the MX31RM.
>
> This patch fixes the CSPI1 IOMUX and makes the LCD to be functional.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Applied to -for-next
Sascha
> ---
> Changes since v1:
>
> - Provided better explanation about this change on the commit message
>
> arch/arm/mach-imx/mach-mx31_3ds.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-imx/mach-mx31_3ds.c b/arch/arm/mach-imx/mach-mx31_3ds.c
> index ab2a626..a6160ee 100644
> --- a/arch/arm/mach-imx/mach-mx31_3ds.c
> +++ b/arch/arm/mach-imx/mach-mx31_3ds.c
> @@ -53,11 +53,8 @@ static int mx31_3ds_pins[] = {
> MX31_PIN_RXD1__RXD1,
> IOMUX_MODE(MX31_PIN_GPIO1_1, IOMUX_CONFIG_GPIO),
> /*SPI0*/
> - MX31_PIN_CSPI1_SCLK__SCLK,
> - MX31_PIN_CSPI1_MOSI__MOSI,
> - MX31_PIN_CSPI1_MISO__MISO,
> - MX31_PIN_CSPI1_SPI_RDY__SPI_RDY,
> - MX31_PIN_CSPI1_SS2__SS2, /* CS for LCD */
> + IOMUX_MODE(MX31_PIN_DSR_DCE1, IOMUX_CONFIG_ALT1),
> + IOMUX_MODE(MX31_PIN_RI_DCE1, IOMUX_CONFIG_ALT1),
> /* SPI 1 */
> MX31_PIN_CSPI2_SCLK__SCLK,
> MX31_PIN_CSPI2_MOSI__MOSI,
> @@ -690,6 +687,9 @@ static void __init mx31_3ds_init(void)
> int ret;
>
> imx31_soc_init();
> +
> + /* Configure SPI1 IOMUX */
> + mxc_iomux_set_gpr(MUX_PGP_CSPI_BB, true);
>
> mxc_iomux_setup_multiple_pins(mx31_3ds_pins, ARRAY_SIZE(mx31_3ds_pins),
> "mx31_3ds");
> --
> 1.6.0.4
>
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2011-06-21 12:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-20 13:37 [PATCH v2] ARM: mach-imx/mx31_3ds: Fix IOMUX for SPI1 signals Fabio Estevam
2011-06-21 12:07 ` Sascha Hauer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110621120719.GY23771@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).