From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] ARM: EXYNOS4: Support early wakeup while entering sleep mode
Date: Wed, 22 Jun 2011 15:57:15 +0100 [thread overview]
Message-ID: <20110622145715.GS23234@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1308732405-16664-5-git-send-email-kgene.kim@samsung.com>
On Wed, Jun 22, 2011 at 05:46:42PM +0900, Kukjin Kim wrote:
> diff --git a/arch/arm/mach-exynos4/sleep.S b/arch/arm/mach-exynos4/sleep.S
> index 6b62425..d55d38c 100644
> --- a/arch/arm/mach-exynos4/sleep.S
> +++ b/arch/arm/mach-exynos4/sleep.S
> @@ -45,11 +45,20 @@ ENTRY(s3c_cpu_save)
> ldr r3, =resume_with_mmu
> bl cpu_suspend
>
> - ldr r0, =pm_cpu_sleep
> - ldr r0, [ r0 ]
> - mov pc, r0
> + bl exynos4_cpu_suspend
> +
> + /* Restore original sp */
> + mov r0, sp
> + add r0, r0, #4
> + ldr sp, [r0]
> +
> + mov r0, #0
> + b early_wakeup
>
> resume_with_mmu:
> + mov r0, #1
> +
> +early_wakeup:
> ldmfd sp!, { r3 - r12, pc }
NAK.
If we want to return from cpu_suspend() stuff then we need to solve this
properly, as per my patch sent around 13th June to the hibernate thread.
Stop bodging stuff (like you have for the SCU stuff.) and start _talking_
to people if the code doesn't do what you need it to do.
next prev parent reply other threads:[~2011-06-22 14:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 8:46 [PATCH 0/7] ARM: EXYNOS4: Update PM Kukjin Kim
2011-06-22 8:46 ` [PATCH 1/7] ARM: EXYNOS4: Support system level power down configuration Kukjin Kim
2011-06-22 8:46 ` [PATCH 2/7] ARM: EXYNOS4: Remove PMU configuration for S2RAM Kukjin Kim
2011-06-22 8:46 ` [PATCH 3/7] ARM: EXYNOS4: Add support PM with external GIC Kukjin Kim
2011-06-22 8:46 ` [PATCH 4/7] ARM: EXYNOS4: Support early wakeup while entering sleep mode Kukjin Kim
2011-06-22 14:57 ` Russell King - ARM Linux [this message]
2011-06-24 7:42 ` Kukjin Kim
2011-06-24 9:37 ` Russell King - ARM Linux
2011-06-24 10:22 ` Russell King - ARM Linux
2011-07-01 1:03 ` Kukjin Kim
2011-07-01 7:44 ` Russell King - ARM Linux
2011-07-04 9:42 ` Kukjin Kim
2011-07-04 9:52 ` Russell King - ARM Linux
2011-06-29 4:58 ` Kukjin Kim
2011-06-22 8:46 ` [PATCH 5/7] ARM: EXYNOS4: Add save/restore function for PLL Kukjin Kim
2011-06-22 8:46 ` [PATCH 6/7] ARM: EXYNOS4: Add save/restore for more ARM registers Kukjin Kim
2011-06-22 14:54 ` Russell King - ARM Linux
2011-06-23 6:39 ` Kukjin Kim
2011-06-23 7:51 ` Russell King - ARM Linux
2011-06-23 8:00 ` Kukjin Kim
2011-06-22 8:46 ` [PATCH 7/7] ARM: EXYNOS4: Move S5P_CENTRAL_SEQ_CONFIGURATION setting for PM Kukjin Kim
2011-06-22 12:10 ` Sergei Shtylyov
2011-06-23 8:05 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110622145715.GS23234@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).