From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/7] ARM: SAMSUNG: Add SPI clock definitions for SAMSUNG SoCs
Date: Thu, 30 Jun 2011 10:30:24 +0100 [thread overview]
Message-ID: <20110630093024.GT21898@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1309436723-662-4-git-send-email-padma.v@samsung.com>
On Thu, Jun 30, 2011 at 08:25:19AM -0400, Padmavathi Venna wrote:
> SPI Clocks were defined in dev-spi.c of machine specific folder.
> To make SPI devices common across all SoCs,dev-spi.c is moved
> from machine specific folder to plat-samsung. So SPI clock
> definitions has been moved from dev-spi.c to SoC specific machine
> folder for S3C64XX,S5P64X0,S5PC100 and S5PV210
This just shows how sick the Samsung code is by abusing the clk API.
If it stopped that abuse and switched over to clkdev none of this would
be necessary.
So I'm going to NAK this until the Samsung clk code moves over to clkdev.
Sorry, I've made enough requests of Samsung people to do this, and its
time for more effective persuasion by standing in the way of other patches
to make it happen.
next prev parent reply other threads:[~2011-06-30 9:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 12:25 [PATCH 0/7] ARM: SAMSUNG: Cleanup SPI platform specific code Padmavathi Venna
2011-06-30 7:31 ` Jassi Brar
2011-06-30 9:27 ` padma venkat
2011-06-30 10:14 ` Jassi Brar
2011-06-30 9:25 ` Marek Szyprowski
2011-07-01 3:35 ` padma venkat
2011-06-30 12:25 ` [PATCH 1/7] ARM: SAMSUNG: Move SPI device definitions to plat-samsung Padmavathi Venna
2011-06-30 12:25 ` [PATCH 2/7] ARM: SAMSUNG: Define common macro for SPI physical address Padmavathi Venna
2011-06-30 12:25 ` [PATCH 3/7] ARM: SAMSUNG: Add SPI clock definitions for SAMSUNG SoCs Padmavathi Venna
2011-06-30 9:30 ` Russell King - ARM Linux [this message]
2011-06-30 9:43 ` Jassi Brar
2011-07-01 3:31 ` padma venkat
2011-06-30 12:25 ` [PATCH 4/7] ARM: SAMSUNG: Create SPI device setup files in respective machine folder Padmavathi Venna
2011-06-30 12:25 ` [PATCH 5/7] ARM: SAMSUNG: Add SPI platform specific code Padmavathi Venna
2011-06-30 12:25 ` [PATCH 6/7] SPI: S5PC100: Enable the SPI driver for S5PC100 Padmavathi Venna
2011-06-30 12:25 ` [PATCH 7/7] SPI: S5PV210: Enable the SPI driver for S5PV210 Padmavathi Venna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110630093024.GT21898@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).