From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 1/3] MTD : add the common code for GPMI-NFC controller driver
Date: Thu, 30 Jun 2011 12:27:28 +0200 [thread overview]
Message-ID: <20110630102728.GB1997@pengutronix.de> (raw)
In-Reply-To: <1309335878-16678-2-git-send-email-b32955@freescale.com>
> +static int mil_ecc_write_oob(struct mtd_info *mtd,
> + struct nand_chip *nand, int page)
> +{
> + struct gpmi_nfc_data *this = nand->priv;
> + struct device *dev = this->dev;
> + struct mil *mil = &this->mil;
> + uint8_t *block_mark;
> + int block_mark_column;
> + int status;
> + int error = 0;
> +
> + /* Only marking a block bad is permitted to write the OOB. */
> + if (!mil->marking_a_bad_block) {
> + dev_emerg(dev, "This driver doesn't support writing the OOB\n");
> + WARN_ON(1);
> + error = -EIO;
> + goto exit;
> + }
Huh? Why is that? This will break JFFS2, for example.
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20110630/1c60291e/attachment.sig>
next prev parent reply other threads:[~2011-06-30 10:27 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 8:24 [PATCH v7 0/3] add the GPMI controller driver for IMX23/IMX28 Huang Shijie
2011-06-29 8:24 ` Huang Shijie
2011-06-29 8:24 ` [PATCH v7 1/3] MTD : add the common code for GPMI-NFC controller driver Huang Shijie
2011-06-29 10:06 ` Wolfram Sang
2011-06-29 10:33 ` Wolfram Sang
2011-06-29 10:46 ` Huang Shijie
2011-06-29 12:29 ` Wolfram Sang
2011-06-29 12:42 ` Russell King - ARM Linux
2011-06-29 12:49 ` Wolfram Sang
2011-06-29 14:00 ` Shawn Guo
2011-06-29 14:15 ` Wolfram Sang
2011-06-29 14:37 ` Shawn Guo
2011-06-30 4:46 ` Wolfram Sang
2011-06-30 5:28 ` Shawn Guo
2011-06-30 8:06 ` [PATCH] dmaengine: mxs-dma: skip request_irq for NO_IRQ Shawn Guo
2011-07-07 0:15 ` Shawn Guo
2011-07-07 2:06 ` Vinod Koul
2011-07-07 3:24 ` Shawn Guo
2011-07-07 3:23 ` Huang Shijie
2011-07-13 23:31 ` Koul, Vinod
2011-06-29 12:38 ` [PATCH v7 1/3] MTD : add the common code for GPMI-NFC controller driver Russell King - ARM Linux
2011-06-30 1:50 ` Huang Shijie
2011-06-30 10:27 ` Wolfram Sang [this message]
2011-06-30 17:04 ` Wolfram Sang
2011-07-01 5:41 ` Artem Bityutskiy
2011-07-01 6:47 ` Huang Shijie
2011-06-29 8:24 ` [PATCH v7 2/3] MTD : add support for imx23 and imx28 Huang Shijie
2011-06-29 8:24 ` [PATCH v7 3/3] MTD : add GPMI-NFC driver in the config and Makefile Huang Shijie
2011-06-30 10:40 ` [PATCH v7 0/3] add the GPMI controller driver for IMX23/IMX28 Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110630102728.GB1997@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).