From: broonie@opensource.wolfsonmicro.com (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/6] Samsung SoC ADC: use regulator (VDD for ADC).
Date: Thu, 30 Jun 2011 09:05:02 -0700 [thread overview]
Message-ID: <20110630160501.GG3249@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <201106301122.50800.anarsoul@gmail.com>
On Thu, Jun 30, 2011 at 11:22:50AM +0300, Vasily Khoruzhick wrote:
> On Thursday 30 June 2011 10:49:30 MyungJoo Ham wrote:
> > + adc->vdd = regulator_get(dev, "vdd");
> > + if (IS_ERR(adc->vdd)) {
> > + dev_err(dev, "operating without regulator \"vdd\" .\n");
> > + ret = PTR_ERR(adc->vdd);
> > + goto err_alloc;
> > + }
> > +
> NACK. Make it optional, otherwise it breaks s3c24xx.
No, the above code is how the regulator API should be used. The API
will stub itself out if not in use so unless the s3c24xx platforms are
using regulators and there's a couple of options in the regulator API
for handling partially defined hookups of regulators on the board.
If there isn't a separate supply for the regulators on S3C24xx devices
then I guess the best option is to provide that supply as a dummy
regulator in the s3c24xx core code.
next prev parent reply other threads:[~2011-06-30 16:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 7:49 [PATCH v3 0/6] Update Samsung-SoC ADC to support recent CPUs MyungJoo Ham
2011-06-30 7:49 ` [PATCH v3 1/6] Samsung SoC ADC: use regulator (VDD for ADC) MyungJoo Ham
2011-06-30 8:22 ` Vasily Khoruzhick
2011-06-30 9:03 ` MyungJoo Ham
2011-06-30 16:05 ` Mark Brown [this message]
2011-07-16 5:07 ` Kukjin Kim
2011-07-19 15:40 ` Mark Brown
2011-07-20 12:23 ` Kukjin Kim
2011-06-30 7:49 ` [PATCH v3 2/6] Samsung SoC ADC: Channel selection for S5PV210, S5PC110, and Exynos4 MyungJoo Ham
2011-06-30 7:49 ` [PATCH v3 3/6] Samsung SoC ADC: Revise PM for 12-bit ADC operations MyungJoo Ham
2011-06-30 7:49 ` [PATCH v3 4/6] ARM: EXYNOS4: Support ADC MyungJoo Ham
2011-06-30 7:49 ` [PATCH v3 5/6] ARM: S5PC110/S5PV210: " MyungJoo Ham
2011-06-30 7:49 ` [PATCH v3 6/6] Samsung SoC: header file revised to prevent declaring duplicated MyungJoo Ham
2011-07-20 12:22 ` [PATCH v3 0/6] Update Samsung-SoC ADC to support recent CPUs Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110630160501.GG3249@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).