From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 9/10] arch/arm/mach-omap2/clock.c: add missing clk_put
Date: Fri, 1 Jul 2011 00:15:05 -0700 [thread overview]
Message-ID: <20110701071505.GB23145@atomide.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1106021526220.26852@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [110602 14:22]:
> On Wed, 1 Jun 2011, Julia Lawall wrote:
>
> > From: Julia Lawall <julia@diku.dk>
> >
> > Add missing call to clk_put.
> >
> > A simplified version of the semantic match that finds this problem is as
> > follows: (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @r exists@
> > expression e1,e2;
> > statement S;
> > @@
> >
> > e1 = clk_get at p1(...);
> > ... when != e1 = e2
> > when != clk_put(e1)
> > when any
> > if (...) { ... when != clk_put(e1)
> > when != if (...) { ... clk_put(e1) ... }
> > * return at p3 ...;
> > } else S
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <julia@diku.dk>
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
Adding this into devel-fixes branch.
Tony
prev parent reply other threads:[~2011-07-01 7:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 17:10 [PATCH 9/10] arch/arm/mach-omap2/clock.c: add missing clk_put Julia Lawall
2011-06-02 21:26 ` Paul Walmsley
2011-07-01 7:15 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110701071505.GB23145@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).