* [PATCH 9/10] arch/arm/mach-omap2/clock.c: add missing clk_put
@ 2011-06-01 17:10 Julia Lawall
2011-06-02 21:26 ` Paul Walmsley
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2011-06-01 17:10 UTC (permalink / raw)
To: linux-arm-kernel
From: Julia Lawall <julia@diku.dk>
Add missing call to clk_put.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
@r exists@
expression e1,e2;
statement S;
@@
e1 = clk_get at p1(...);
... when != e1 = e2
when != clk_put(e1)
when any
if (...) { ... when != clk_put(e1)
when != if (...) { ... clk_put(e1) ... }
* return at p3 ...;
} else S
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
---
arch/arm/mach-omap2/clock.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-omap2/clock.c b/arch/arm/mach-omap2/clock.c
index 180299e..bf9c36c 100644
--- a/arch/arm/mach-omap2/clock.c
+++ b/arch/arm/mach-omap2/clock.c
@@ -453,6 +453,7 @@ int __init omap2_clk_switch_mpurate_at_boot(const char *mpurate_ck_name)
if (IS_ERR_VALUE(r)) {
WARN(1, "clock: %s: unable to set MPU rate to %d: %d\n",
mpurate_ck->name, mpurate, r);
+ clk_put(mpurate_ck);
return -EINVAL;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 9/10] arch/arm/mach-omap2/clock.c: add missing clk_put
2011-06-01 17:10 [PATCH 9/10] arch/arm/mach-omap2/clock.c: add missing clk_put Julia Lawall
@ 2011-06-02 21:26 ` Paul Walmsley
2011-07-01 7:15 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Paul Walmsley @ 2011-06-02 21:26 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 1 Jun 2011, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Add missing call to clk_put.
>
> A simplified version of the semantic match that finds this problem is as
> follows: (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @r exists@
> expression e1,e2;
> statement S;
> @@
>
> e1 = clk_get at p1(...);
> ... when != e1 = e2
> when != clk_put(e1)
> when any
> if (...) { ... when != clk_put(e1)
> when != if (...) { ... clk_put(e1) ... }
> * return at p3 ...;
> } else S
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Paul Walmsley <paul@pwsan.com>
- Paul
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH 9/10] arch/arm/mach-omap2/clock.c: add missing clk_put
2011-06-02 21:26 ` Paul Walmsley
@ 2011-07-01 7:15 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2011-07-01 7:15 UTC (permalink / raw)
To: linux-arm-kernel
* Paul Walmsley <paul@pwsan.com> [110602 14:22]:
> On Wed, 1 Jun 2011, Julia Lawall wrote:
>
> > From: Julia Lawall <julia@diku.dk>
> >
> > Add missing call to clk_put.
> >
> > A simplified version of the semantic match that finds this problem is as
> > follows: (http://coccinelle.lip6.fr/)
> >
> > // <smpl>
> > @r exists@
> > expression e1,e2;
> > statement S;
> > @@
> >
> > e1 = clk_get at p1(...);
> > ... when != e1 = e2
> > when != clk_put(e1)
> > when any
> > if (...) { ... when != clk_put(e1)
> > when != if (...) { ... clk_put(e1) ... }
> > * return at p3 ...;
> > } else S
> > // </smpl>
> >
> > Signed-off-by: Julia Lawall <julia@diku.dk>
>
> Acked-by: Paul Walmsley <paul@pwsan.com>
Adding this into devel-fixes branch.
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-01 7:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-01 17:10 [PATCH 9/10] arch/arm/mach-omap2/clock.c: add missing clk_put Julia Lawall
2011-06-02 21:26 ` Paul Walmsley
2011-07-01 7:15 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).