From: plagnioj@jcrosoft.com (Jean-Christophe PLAGNIOL-VILLARD)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/8] at91: add arch specific ioremap support
Date: Fri, 1 Jul 2011 19:29:12 +0200 [thread overview]
Message-ID: <20110701172912.GI14408@game.jcrosoft.org> (raw)
In-Reply-To: <201107011759.38038.arnd@arndb.de>
On 17:59 Fri 01 Jul , Arnd Bergmann wrote:
> On Friday 01 July 2011, Jean-Christophe PLAGNIOL-VILLARD wrote:
>
> > +
> > +static inline unsigned int at91_readl(unsigned int pa)
> > +{
> > + return __raw_readl((void __iomem *)AT91_IO_P2V(pa));
> > +}
> > +
>
> This function looks quite unusual and not in a good way. You also don't
> seem to use it at all.
>
> Why is this needed, can can't you change all users to do ioremap?
I don't remember why I put it
the whole idea is that everyone use ioremap now
Best Regards,
J.
next prev parent reply other threads:[~2011-07-01 17:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 6:44 [PATCH 1/8] at91: introduce commom AT91_BASE_SYS Jean-Christophe PLAGNIOL-VILLARD
2011-07-01 6:44 ` [PATCH 2/8] at91: factorize at91 interrupts init to soc Jean-Christophe PLAGNIOL-VILLARD
2011-07-01 15:47 ` Arnd Bergmann
2011-07-01 17:26 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-04 9:19 ` Christian Glindkamp
2011-07-05 5:37 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-01 6:44 ` [PATCH 3/8] at91: remove AT91_DBGU offset from dbgu register macro Jean-Christophe PLAGNIOL-VILLARD
2011-07-01 15:49 ` Arnd Bergmann
2011-07-27 12:05 ` [PATCH 3/8 v2] " Jean-Christophe PLAGNIOL-VILLARD
2011-07-01 6:44 ` [PATCH 4/8] at91: use structure to store the current soc Jean-Christophe PLAGNIOL-VILLARD
2011-07-01 6:44 ` [PATCH 5/8] at91: move clock subsystem init to soc generic init Jean-Christophe PLAGNIOL-VILLARD
2011-07-01 6:44 ` [PATCH 6/8] at91: move register clocks " Jean-Christophe PLAGNIOL-VILLARD
2011-07-01 6:44 ` [PATCH 7/8] at91: factorize sram init Jean-Christophe PLAGNIOL-VILLARD
2011-07-01 6:44 ` [PATCH 8/8] at91: add arch specific ioremap support Jean-Christophe PLAGNIOL-VILLARD
2011-07-01 15:59 ` Arnd Bergmann
2011-07-01 17:29 ` Jean-Christophe PLAGNIOL-VILLARD [this message]
2011-07-01 15:46 ` [PATCH 1/8] at91: introduce commom AT91_BASE_SYS Arnd Bergmann
2011-07-01 17:25 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-01 20:38 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110701172912.GI14408@game.jcrosoft.org \
--to=plagnioj@jcrosoft.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).