From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] serial/imx: get rid of the uses of cpu_is_mx1()
Date: Sun, 3 Jul 2011 23:38:28 -0600 [thread overview]
Message-ID: <20110704053828.GB15152@ponder.secretlab.ca> (raw)
In-Reply-To: <20110704021923.GA10245@S2100-06.ap.freescale.net>
On Mon, Jul 04, 2011 at 10:19:25AM +0800, Shawn Guo wrote:
> > > @@ -689,7 +728,7 @@ static int imx_startup(struct uart_port *port)
> > > }
> > > }
> > >
> > > - if (!cpu_is_mx1()) {
> > > + if (IS_IMX2_UART()) {
> >
> > The logic is getting reversed here, is this really what you want to
> > do? I would think you'd want to preserve the !IS_IMX1_UART() logic.
> >
> Maybe not. I actually made a small improvement here. The body of
> the 'if' is really IMX2 specific code, so it makes more sense to use
> IS_IMX2_UART() than !IS_IMX1_UART().
Okay, it would probably be worth mentioning this change in the commit text.
next prev parent reply other threads:[~2011-07-04 5:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-03 7:55 [PATCH 0/2] Add device tree probe support for tty/serial/imx Shawn Guo
2011-07-03 7:55 ` [PATCH 1/2] serial/imx: get rid of the uses of cpu_is_mx1() Shawn Guo
2011-07-03 21:10 ` Grant Likely
2011-07-04 2:19 ` Shawn Guo
2011-07-04 5:38 ` Grant Likely [this message]
2011-07-04 7:33 ` Uwe Kleine-König
2011-07-04 8:43 ` Shawn Guo
2011-07-04 9:28 ` Uwe Kleine-König
2011-07-04 10:26 ` Shawn Guo
2011-07-03 7:56 ` [PATCH 2/2] serial/imx: add device tree probe support Shawn Guo
2011-07-03 21:14 ` Grant Likely
2011-07-04 2:36 ` Shawn Guo
2011-07-04 6:58 ` Sascha Hauer
2011-07-04 7:38 ` Uwe Kleine-König
2011-07-04 9:05 ` Shawn Guo
2011-07-04 9:10 ` Uwe Kleine-König
2011-07-04 15:33 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704053828.GB15152@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).