From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] ARM: EXYNOS4: Support early wakeup while entering sleep mode
Date: Mon, 4 Jul 2011 10:52:14 +0100 [thread overview]
Message-ID: <20110704095214.GA8286@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <005001cc3a2e$a6689480$f339bd80$%kim@samsung.com>
On Mon, Jul 04, 2011 at 06:42:08PM +0900, Kukjin Kim wrote:
> Russell King - ARM Linux wrote:
> >
> > On Fri, Jul 01, 2011 at 10:03:48AM +0900, Kukjin Kim wrote:
> > > Russell thanks.
> > >
> > > How do you think to add following for handling failure of cpu_suspend?
> > >
> > > + mov r0, #-1
> >
> > No. -1 is not an error code, and I refuse to create functions which
> > use an explicit -1 as a return code to indicate failure.
> >
> I used wrong words, 'handling failure' :(
>
> Actually, it means handling other case, like early wakeup but we will
> address comments from you :)
Bear in mind that others may wish to return negative errno codes
through this, so if you want to indicate 'no need to resume and
restore state' then I guess using a small positive number would be
acceptable to distinguish it from a real error.
next prev parent reply other threads:[~2011-07-04 9:52 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 8:46 [PATCH 0/7] ARM: EXYNOS4: Update PM Kukjin Kim
2011-06-22 8:46 ` [PATCH 1/7] ARM: EXYNOS4: Support system level power down configuration Kukjin Kim
2011-06-22 8:46 ` [PATCH 2/7] ARM: EXYNOS4: Remove PMU configuration for S2RAM Kukjin Kim
2011-06-22 8:46 ` [PATCH 3/7] ARM: EXYNOS4: Add support PM with external GIC Kukjin Kim
2011-06-22 8:46 ` [PATCH 4/7] ARM: EXYNOS4: Support early wakeup while entering sleep mode Kukjin Kim
2011-06-22 14:57 ` Russell King - ARM Linux
2011-06-24 7:42 ` Kukjin Kim
2011-06-24 9:37 ` Russell King - ARM Linux
2011-06-24 10:22 ` Russell King - ARM Linux
2011-07-01 1:03 ` Kukjin Kim
2011-07-01 7:44 ` Russell King - ARM Linux
2011-07-04 9:42 ` Kukjin Kim
2011-07-04 9:52 ` Russell King - ARM Linux [this message]
2011-06-29 4:58 ` Kukjin Kim
2011-06-22 8:46 ` [PATCH 5/7] ARM: EXYNOS4: Add save/restore function for PLL Kukjin Kim
2011-06-22 8:46 ` [PATCH 6/7] ARM: EXYNOS4: Add save/restore for more ARM registers Kukjin Kim
2011-06-22 14:54 ` Russell King - ARM Linux
2011-06-23 6:39 ` Kukjin Kim
2011-06-23 7:51 ` Russell King - ARM Linux
2011-06-23 8:00 ` Kukjin Kim
2011-06-22 8:46 ` [PATCH 7/7] ARM: EXYNOS4: Move S5P_CENTRAL_SEQ_CONFIGURATION setting for PM Kukjin Kim
2011-06-22 12:10 ` Sergei Shtylyov
2011-06-23 8:05 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704095214.GA8286@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).