From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: what about mach-shark?
Date: Mon, 4 Jul 2011 23:05:21 +0100 [thread overview]
Message-ID: <20110704220521.GI8286@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.00.1107041545480.14596@xanadu.home>
On Mon, Jul 04, 2011 at 04:08:56PM -0400, Nicolas Pitre wrote:
>
> Is this used?
>
> While it probably does compile, it is likely to oops soon after boot. I
> notice that it defines UNCACHEABLE_ADDR to 0xdf010000 in
> mach-shark/include/mach/hardware.h which is used by cpu_sa110_do_idle in
> mm/proc-sa110.S, and therefore it must be a virtual address. However I
> can't find where this 0xdf010000 is actually mapped.
>
> So either no one has been using this for a long time as this is not
> going to run past a schedule to the idle loop, or I'm missing something
> obvious. If the former I'm proposing to remove mach-shark from the
> tree, if the later I'd like to know where the actual mapping for that
> 0xdf010000 is.
You're missing something.
FYI:
arch/arm/mach-shark/include/mach/memory.h:#define FLUSH_BASE 0xdf000000
arch/arm/mm/mmu.c:
/*
* Map the cache flushing regions.
*/
#ifdef FLUSH_BASE
map.pfn = __phys_to_pfn(FLUSH_BASE_PHYS);
map.virtual = FLUSH_BASE;
map.length = SZ_1M;
map.type = MT_CACHECLEAN;
create_mapping(&map);
#endif
#ifdef FLUSH_BASE_MINICACHE
map.pfn = __phys_to_pfn(FLUSH_BASE_PHYS + SZ_1M);
map.virtual = FLUSH_BASE_MINICACHE;
map.length = SZ_1M;
map.type = MT_MINICLEAN;
create_mapping(&map);
#endif
And 64K < 1M, so its covered by the cache flush mapping. Exactly the
same applies to RiscPC which worked last time I tried it.
next prev parent reply other threads:[~2011-07-04 22:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 20:08 what about mach-shark? Nicolas Pitre
2011-07-04 22:05 ` Russell King - ARM Linux [this message]
2011-07-04 22:20 ` Nicolas Pitre
2011-07-04 22:24 ` Russell King - ARM Linux
2011-07-05 1:51 ` Nicolas Pitre
2013-08-26 19:04 ` Linus Walleij
2013-08-26 19:06 ` Russell King - ARM Linux
2013-08-27 3:16 ` Linus Walleij
2013-08-28 9:05 ` Alexander Schulz
2013-08-28 11:53 ` Linus Walleij
2013-09-02 6:16 ` Alexander Schulz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110704220521.GI8286@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).