From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ohci-at91: add vbus_pin_inverted platform attribute
Date: Tue, 5 Jul 2011 13:54:55 +0200 [thread overview]
Message-ID: <20110705135455.5fa643cc@skate> (raw)
In-Reply-To: <4E12F7E6.7080604@mvista.com>
Le Tue, 05 Jul 2011 15:39:18 +0400,
Sergei Shtylyov <sshtylyov@mvista.com> a ?crit :
> > - gpio_direction_output(pdata->vbus_pin[i], 0);
> > + gpio_direction_output(pdata->vbus_pin[i], 0 ^ pdata->vbus_pin_inverted);
>
> Why not simply 'pdata->vbus_pin_inverted'?
> > - gpio_direction_output(pdata->vbus_pin[i], 1);
> > + gpio_direction_output(pdata->vbus_pin[i], 1 ^ pdata->vbus_pin_inverted);
>
> Why not simply '!pdata->vbus_pin_inverted'?
Ah, correct. The 0 and 1 were present before, and I just wanted to xor
them with vbus_pin_inverted, but obviously, there's a simpler way of
writing things, as you suggest.
I'll update my patch and send a new version after gathering comments
from other reviewers.
Thanks!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2011-07-05 11:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 9:05 [PATCH 1/3] ohci-at91: add vbus_pin_inverted platform attribute Thomas Petazzoni
2011-07-05 9:05 ` [PATCH 2/3] at91-ohci: support overcurrent notification Thomas Petazzoni
2011-07-05 10:12 ` Matthieu CASTET
2011-07-05 10:18 ` Thomas Petazzoni
2011-07-05 12:18 ` Matthieu CASTET
2011-07-05 14:23 ` Jean-Christophe PLAGNIOL-VILLARD
2011-07-05 9:05 ` [PATCH 3/3] at91-ohci: configure overcurrent pins as GPIOs Thomas Petazzoni
2011-07-05 11:39 ` [PATCH 1/3] ohci-at91: add vbus_pin_inverted platform attribute Sergei Shtylyov
2011-07-05 11:54 ` Thomas Petazzoni [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-07-13 9:29 [PATCH v2] AT91 OHCI active-high vbus and overcurrent handling Thomas Petazzoni
2011-07-13 9:29 ` [PATCH 1/3] ohci-at91: add vbus_pin_inverted platform attribute Thomas Petazzoni
2011-09-07 10:47 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110705135455.5fa643cc@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox