public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] remove unnecessary cache flush on v6 copypage
Date: Thu, 7 Jul 2011 09:15:37 +0100	[thread overview]
Message-ID: <20110707081537.GG8286@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAN_5kQDTweB2GLvwgjN+BQuqnhFUp+MOcQr=ZW=8C6XSsC8XtA@mail.gmail.com>

On Wed, Jul 06, 2011 at 07:19:59PM -0700, heechul Yun wrote:
> ARM: mm: remove unnecessary cache flush on v6 copypage
> 
> Signed-off-by: Heechul Yun <heechul@illinois.edu>
> --
> arch/arm/mm/copypage-v6.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mm/copypage-v6.c b/arch/arm/mm/copypage-v6.c
> index bdba6c6..63cca00 100644
> --- a/arch/arm/mm/copypage-v6.c
> +++ b/arch/arm/mm/copypage-v6.c
> @@ -41,7 +41,6 @@ static void v6_copy_user_highpage_nonaliasing(struct page *to,
>        kfrom = kmap_atomic(from, KM_USER0);
>        kto = kmap_atomic(to, KM_USER1);
>        copy_page(kto, kfrom);
> -       __cpuc_flush_dcache_area(kto, PAGE_SIZE);
>        kunmap_atomic(kto, KM_USER1);
>        kunmap_atomic(kfrom, KM_USER0);
>  }

Patch looks good, except that it's whitespace damaged (the tabs are
replaced by spaces) which makes it hard to apply.  Could you try to
sort that out.  Documentation/email-clients.txt in the kernel tree
may help with that.

I assume Catalin will (eventually) provide an ack - and at that point
please submit it (in non-whitespace damaged form) to the patch system,
thanks.

  reply	other threads:[~2011-07-07  8:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07  2:19 [PATCH] remove unnecessary cache flush on v6 copypage heechul Yun
2011-07-07  8:15 ` Russell King - ARM Linux [this message]
2011-07-07  9:02 ` Catalin Marinas
2011-07-07 10:31   ` saeed bishara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110707081537.GG8286@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox