public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2] remove unnecessary cache flush on v6 copypage
Date: Fri, 8 Jul 2011 10:47:22 +0100	[thread overview]
Message-ID: <20110708094722.GC16293@e102109-lin.cambridge.arm.com> (raw)
In-Reply-To: <20110708093542.GA4812@n2100.arm.linux.org.uk>

On Fri, Jul 08, 2011 at 10:35:42AM +0100, Russell King - ARM Linux wrote:
> On Thu, Jul 07, 2011 at 09:30:19AM -0500, Heechul Yun wrote:
> > ARM: mm: remove unnecessary cache flush on v6 copypage
> > 
> > Originally introduced to maintain coherency between icache and dcache
> > in v6 nonaliasing mode. This is now handled by __sync_icache_dcache since
> > c0177800, therefore unneceary in this function.  
> > 
> > Signed-off-by: Heechul Yun <heechul@illinois.edu>
> > Acked-by: Catalin Marinas <catalin.marinas@arm.com>
> > --
> > arch/arm/mm/copypage-v6.c |    1 -
> >  1 files changed, 0 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/arm/mm/copypage-v6.c b/arch/arm/mm/copypage-v6.c
> > index bdba6c6..63cca00 100644
> > --- a/arch/arm/mm/copypage-v6.c
> > +++ b/arch/arm/mm/copypage-v6.c
> > @@ -41,7 +41,6 @@ static void v6_copy_user_highpage_nonaliasing(struct page *to,
> >  	kfrom = kmap_atomic(from, KM_USER0);
> >  	kto = kmap_atomic(to, KM_USER1);
> >  	copy_page(kto, kfrom);
> > -	__cpuc_flush_dcache_area(kto, PAGE_SIZE);
> >  	kunmap_atomic(kto, KM_USER1);
> >  	kunmap_atomic(kfrom, KM_USER0);
> >  }
> 
> The above patch is fine (it has tabs preserved) but the version in the
> patch system has spaces instead (each space character has been replaced
> with a '.') and so doesn't apply:

Does your patch system now understand a From: line in the patch log (and
preserve the author)? I can upload the patch on Heechul's behalf.

-- 
Catalin

  reply	other threads:[~2011-07-08  9:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-07 14:30 [PATCHv2] remove unnecessary cache flush on v6 copypage Heechul Yun
2011-07-07 14:49 ` Catalin Marinas
2011-07-08  9:35 ` Russell King - ARM Linux
2011-07-08  9:47   ` Catalin Marinas [this message]
2011-07-08 12:52   ` heechul Yun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110708094722.GC16293@e102109-lin.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox