From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mmp: remove builtin gpio driver support
Date: Sun, 10 Jul 2011 13:02:18 +0900 [thread overview]
Message-ID: <20110710040218.GA10912@ponder.secretlab.ca> (raw)
In-Reply-To: <1310120428-22700-2-git-send-email-haojian.zhuang@marvell.com>
On Fri, Jul 08, 2011 at 06:20:18PM +0800, Haojian Zhuang wrote:
> Remove builtin gpio driver support form mmp.
>
> Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
Hi Haojian.
I'm not clear what this patch is intending to do. I understand that
it removes the mmp-specific gpio support, but I looks like don't see the code
that replaces it, which would mean that applying this patch breaks
gpio on mmp platforms.
Am I missing something?
> diff --git a/arch/arm/plat-pxa/Makefile b/arch/arm/plat-pxa/Makefile
> index 3aca5ba..8e432b1 100644
> --- a/arch/arm/plat-pxa/Makefile
> +++ b/arch/arm/plat-pxa/Makefile
> @@ -4,7 +4,9 @@
>
> obj-y := dma.o
>
> +ifeq ($(CONFIG_OF),)
> obj-$(CONFIG_GENERIC_GPIO) += gpio.o
> +endif
Be careful about this. Turning on device tree support must not
disable booting on non-DT machines.
g.
next prev parent reply other threads:[~2011-07-10 4:02 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-08 10:20 [PATCH] ARM: mmp: remove SPARSE_IRQ for mmp Haojian Zhuang
2011-07-08 10:20 ` [PATCH] ARM: mmp: remove builtin gpio driver support Haojian Zhuang
2011-07-08 10:20 ` [PATCH] ARM: mmp: parse irq from DT Haojian Zhuang
2011-07-08 10:20 ` [PATCH] ARM: mmp: support OF by default Haojian Zhuang
2011-07-08 10:20 ` [PATCH] tty: serial: support device tree in pxa Haojian Zhuang
2011-07-08 10:20 ` [PATCH] tty: serial: check ops before registering console Haojian Zhuang
2011-07-08 10:20 ` [PATCH] i2c: pxa: create dynamic platform device from device tree Haojian Zhuang
2011-07-08 10:20 ` [PATCH] of: add devicetree API for regulator Haojian Zhuang
2011-07-08 10:20 ` [PATCH] regulator: convert devicetree to platform data on max8649 Haojian Zhuang
2011-07-08 10:20 ` [PATCH] mfd: convert devicetree to platform data on max8925 Haojian Zhuang
2011-07-08 10:20 ` [PATCH] mfd: convert devicetree to platform on 88pm860x Haojian Zhuang
2011-07-08 10:20 ` [PATCH] ARM: mmp: add DTS file Haojian Zhuang
2011-07-10 7:35 ` Grant Likely
2011-07-11 5:21 ` Haojian Zhuang
2011-07-10 7:21 ` [PATCH] mfd: convert devicetree to platform on 88pm860x Grant Likely
2011-07-10 7:20 ` [PATCH] mfd: convert devicetree to platform data on max8925 Grant Likely
2011-07-10 9:17 ` Mark Brown
2011-07-10 10:40 ` Grant Likely
2011-07-08 14:51 ` [PATCH] of: add devicetree API for regulator Grant Likely
2011-07-09 1:14 ` Mark Brown
2011-07-08 18:32 ` Liam Girdwood
2011-07-09 2:03 ` Mark Brown
2011-07-10 5:26 ` [PATCH] i2c: pxa: create dynamic platform device from device tree Grant Likely
2011-07-10 5:11 ` [PATCH] tty: serial: support device tree in pxa Grant Likely
2011-07-10 4:34 ` [PATCH] ARM: mmp: parse irq from DT Grant Likely
2011-07-10 4:02 ` Grant Likely [this message]
2011-07-11 5:05 ` [PATCH] ARM: mmp: remove builtin gpio driver support Haojian Zhuang
2011-07-11 11:44 ` Eric Miao
2011-07-08 14:46 ` [PATCH] ARM: mmp: remove SPARSE_IRQ for mmp Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110710040218.GA10912@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).