From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] mc13xxx: implicitly enable leds and buttons
Date: Sun, 10 Jul 2011 10:04:50 +0200 [thread overview]
Message-ID: <20110710080450.GW29624@pengutronix.de> (raw)
In-Reply-To: <1310252796-10596-4-git-send-email-philippe.retornaz@epfl.ch>
Hello,
On Sun, Jul 10, 2011 at 01:06:36AM +0200, Philippe R?tornaz wrote:
> The leds and buttons subdevices cannot be used without additional
> platform data.
>
> Use the presence of the platform data to enable the device instead
> of an additional flag.
I guess you could make some people happy by splitting this patch into:
- mfd/mc13xxx: implicitly enable leds and buttons (and
regulators?)
- drop MC13XXX_USE_... in arch code
because the patches have different paths into mainline (unless it's
handled otherwise).
And I wonder why you introduce MC13XXX_USE_BUTTON in the first place.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2011-07-10 8:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-09 23:06 [PATCH v3 0/3] mc13783: add pwr button support Philippe Rétornaz
2011-07-09 23:06 ` [PATCH 1/3] mc13783: add power " Philippe Rétornaz
2011-07-09 23:06 ` [PATCH 2/3] mx31moboard: Add MC13783 " Philippe Rétornaz
2011-07-09 23:06 ` [PATCH 3/3] mc13xxx: implicitly enable leds and buttons Philippe Rétornaz
2011-07-10 8:04 ` Uwe Kleine-König [this message]
2011-07-10 8:37 ` Mark Brown
2011-07-10 11:33 ` Philippe Rétornaz
2011-07-10 14:15 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110710080450.GW29624@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox